Only crash in debug mode, if HTTPClient was not shutdown

Author: fabianfett

Diff for: Sources/AsyncHTTPClient/HTTPClient.swift

@@ -68,7 +68,7 @@ public class HTTPClient {
     let eventLoopGroupProvider: EventLoopGroupProvider
     let configuration: Configuration
     let poolManager: HTTPConnectionPool.Manager
-    var state: State
+    private var state: State
     private let stateLock = Lock()
 
     internal static let loggingDisabled = Logger(label: "AHC-do-not-log", factory: { _ in SwiftLogNoOpLogHandler() })
@@ -118,8 +118,14 @@ public class HTTPClient {
     }
 
     deinit {
-        guard case .shutDown = self.state else {
-            preconditionFailure("Client not shut down before the deinit. Please call client.syncShutdown() when no longer needed.")
+        debugOnly {
+            // We want to crash only in debug mode.
+            switch self.state {
+            case .shutDown:
+                break
+            case .shuttingDown, .upAndRunning:
+                preconditionFailure("Client not shut down before the deinit. Please call client.syncShutdown() when no longer needed.")
+            }
         }
     }
 

Diff for: Sources/AsyncHTTPClient/Utils.swift

@@ -32,3 +32,13 @@ public final class HTTPClientCopyingDelegate: HTTPClientResponseDelegate {
         return ()
     }
 }
+
+/// A utility function that runs the body code only in debug builds, without
+/// emitting compiler warnings.
+///
+/// This is currently the only way to do this in Swift: see
+/// https://forums.swift.org/t/support-debug-only-code/11037 for a discussion.
+@inlinable
+internal func debugOnly(_ body: () -> Void) {
+    assert({ body(); return true }())
+}