Skip to content

Commit eaeb642

Browse files
fabianfettLukasa
andauthored
Apply suggestions from code review
Co-authored-by: Cory Benfield <[email protected]>
1 parent a1ca482 commit eaeb642

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTPExecutingRequest.swift

+2-3
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import NIOHTTP1
2626
///
2727
/// 1. **The request is scheduled to be run.**
2828
/// In this state the HTTP client tries to acquire a connection for the request, and the request
29-
/// may need to wait for a connection)
29+
/// may need to wait for a connection
3030
/// 2. **The request is executing.**
3131
/// In this state the request was written to a NIO channel. A NIO channel handler (abstracted
3232
/// by the `HTTPRequestExecutor` protocol) writes the request's bytes onto the wire and
@@ -130,7 +130,7 @@ import NIOHTTP1
130130
/// Passing along the requests reference helps the executor and scheduler verify its internal
131131
/// state.
132132

133-
/// A handle to the request queuer.
133+
/// A handle to the request scheduler.
134134
///
135135
/// Use this handle to cancel the request, while it is waiting for a free connection, to execute the request.
136136
/// This protocol is only intended to be implemented by the `HTTPConnectionPool`.
@@ -247,4 +247,3 @@ protocol HTTPExecutingRequest: AnyObject {
247247

248248
func fail(_ error: Error)
249249
}
250-

Diff for: Sources/AsyncHTTPClient/RequestBag.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ final class RequestBag<Delegate: HTTPClientResponseDelegate>: HTTPScheduledReque
251251
case .initialized:
252252
preconditionFailure("Request stream must be started before it can be paused")
253253
case .producing:
254-
preconditionFailure("Expected that pause is only called when if we were paused before")
254+
preconditionFailure("Expected that resume is only called when if we were paused before")
255255
case .paused(let promises):
256256
self._state = .executing(executor, .producing, responseState)
257257
return promises

0 commit comments

Comments
 (0)