Skip to content

HTTPClient.Task.fail can release its associated connection more than once #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adam-fowler opened this issue Mar 31, 2020 · 0 comments · Fixed by #192
Closed

HTTPClient.Task.fail can release its associated connection more than once #188

adam-fowler opened this issue Mar 31, 2020 · 0 comments · Fixed by #192
Labels
kind/bug Feature doesn't work as expected.
Milestone
1.2.0

Comments

@adam-fowler
Copy link
Member

This occurs on the NIOTransportServices PR #184. The testStressGetClose() test fails.

It is related to NIOTS returning two errors when it tries to read off a closed channel. HTTPClient.Task.fail is called twice. This then causes connection.release() being called twice which messes up with the connection lease count.
@weissi weissi added the kind/bug Feature doesn't work as expected. label Mar 31, 2020
@weissi weissi added this to the 1.2.0 milestone Mar 31, 2020
@artemredkin artemredkin mentioned this issue May 15, 2020
Merged
@artemredkin artemredkin linked a pull request May 15, 2020 that will close this issue
refactor pool #192
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

refactor pool swift-server/async-http-client
2 participants
@weissi @adam-fowler