Skip to content

add test for error condition in line 151 of ConnectionsState.swift #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weissi opened this issue Jun 13, 2020 · 2 comments
Closed

add test for error condition in line 151 of ConnectionsState.swift #244

weissi opened this issue Jun 13, 2020 · 2 comments
Labels
kind/enhancement Improvements to existing feature.
Milestone
HTTP/2 support

Comments

@weissi
Copy link
Contributor

weissi commented Jun 13, 2020

@artemredkin from what I can tell, no test noticed that this error changed which probably means no test is getting this error ;). I think we should probably add a test case that tests this condition.

Originally posted by @weissi in #240
@weissi weissi changed the title @artemredkin from what I can tell, no test noticed that this error changed which probably means no test is getting this error ;). I think we should probably add a test case that tests this condition. add test for error condition in line 151 of ConnectionsState.swift Jun 13, 2020
@weissi
Copy link
Contributor Author

weissi commented Jun 13, 2020

https://github.com/swift-server/async-http-client/pull/240/files#diff-bfea29858f72f0aa5df7309d1123b672R151

@weissi weissi mentioned this issue Jun 13, 2020
Merged
@artemredkin artemredkin added kind/enhancement Improvements to existing feature. help wanted labels Jun 13, 2020
@artemredkin artemredkin added this to the 1.2.1 milestone Jun 13, 2020
@artemredkin artemredkin modified the milestones: 1.2.1, 1.2.2 Aug 20, 2020
@artemredkin artemredkin modified the milestones: 1.2.2, 1.2.3 Nov 11, 2020
@fabianfett fabianfett modified the milestones: 1.2.3, HTTP/2 support Oct 1, 2021
@fabianfett
Copy link
Member

No longer needed, since the implementation was completely replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
HTTP/2 support
Development

No branches or pull requests
3 participants
@artemredkin @weissi @fabianfett