Skip to content

types should be nested in HTTPClient #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weissi opened this issue Apr 10, 2019 · 3 comments
Closed

types should be nested in HTTPClient #3

weissi opened this issue Apr 10, 2019 · 3 comments
Labels
kind/bug Feature doesn't work as expected.
Milestone
1.0.0

Comments

@weissi
Copy link
Contributor

weissi commented Apr 10, 2019

HTTPClientConfiguration should be HTTPClient.Configuration
HTTPClientErrors should be HTTPClient.Errors
@weissi weissi added this to the 1.0.0 milestone Apr 10, 2019
@weissi weissi added the kind/bug Feature doesn't work as expected. label Apr 10, 2019
@tanner0101
Copy link
Member

@weissi I was going to put up a PR for this one, but I think it would cause conflicts with #1. I'm willing to put one up after #1 is decided on though.

@artemredkin
Copy link
Collaborator

Should we close it? It was fixed by #10

@weissi
Copy link
Contributor Author

weissi commented Apr 15, 2019

Yes thanks all

@weissi weissi closed this as completed Apr 15, 2019
@saroar saroar mentioned this issue Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@artemredkin @weissi @tanner0101