Convert PublicKeyCredentialRequestOptions.timeout to milliseconds (#26)

* Convert PublicKeyCredentialRequestOptions.timeout to milliseconds.

* Add reference to w3.org specification

Author: samalone

Sources/WebAuthn/Ceremonies/Authentication/PublicKeyCredentialRequestOptions.swift

@@ -18,9 +18,10 @@ import Foundation
 public struct PublicKeyCredentialRequestOptions: Codable {
     /// A challenge that the authenticator signs, along with other data, when producing an authentication assertion
     public let challenge: EncodedBase64
-    /// A `TimeInterval`, that the Relying Party is willing to wait for the call to complete. The value is treated
+    /// The number of milliseconds that the Relying Party is willing to wait for the call to complete. The value is treated
     /// as a hint, and may be overridden by the client.
-    public let timeout: TimeInterval?
+    /// See https://www.w3.org/TR/webauthn-2/#dictionary-assertion-options
+    public let timeout: UInt32?
     /// The Relying Party ID.
     public let rpId: String?
     /// Optionally used by the client to find authenticators eligible for this authentication ceremony.

Sources/WebAuthn/WebAuthnManager.swift

@@ -146,9 +146,13 @@ public struct WebAuthnManager {
         userVerification: UserVerificationRequirement = .preferred
     ) throws -> PublicKeyCredentialRequestOptions {
         let challenge = challenge ?? challengeGenerator.generate().base64EncodedString()
+        var timeoutInMilliseconds: UInt32? = nil
+        if let timeout {
+            timeoutInMilliseconds = UInt32(timeout * 1000)
+        }
         return PublicKeyCredentialRequestOptions(
             challenge: challenge,
-            timeout: timeout,
+            timeout: timeoutInMilliseconds,
             rpId: config.relyingPartyID,
             allowCredentials: allowCredentials,
             userVerification: userVerification

Tests/WebAuthnTests/WebAuthnManagerAuthenticationTests.swift

@@ -43,7 +43,7 @@ final class WebAuthnManagerAuthenticationTests: XCTestCase {
         )
 
         XCTAssertEqual(options.challenge, challenge.base64EncodedString())
-        XCTAssertEqual(options.timeout, 1234)
+        XCTAssertEqual(options.timeout, 1234000)    // timeout converted to milliseconds
         XCTAssertEqual(options.rpId, relyingPartyID)
         XCTAssertEqual(options.allowCredentials, allowCredentials)
         XCTAssertEqual(options.userVerification, .preferred)

Tests/WebAuthnTests/WebAuthnManagerIntegrationTests.swift

@@ -108,7 +108,7 @@ final class WebAuthnManagerIntegrationTests: XCTestCase {
         )
 
         XCTAssertEqual(authenticationOptions.rpId, config.relyingPartyID)
-        XCTAssertEqual(authenticationOptions.timeout, authenticationTimeout)
+        XCTAssertEqual(authenticationOptions.timeout, UInt32(authenticationTimeout * 1000)) // timeout is in milliseconds
         XCTAssertEqual(authenticationOptions.challenge, mockChallenge.base64EncodedString())
         XCTAssertEqual(authenticationOptions.userVerification, userVerification)
         XCTAssertEqual(authenticationOptions.allowCredentials, rememberedCredentials)