Skip to content

Commit e3fe1f9

Browse files
authored
[lldb][Modules] Fix error handling of loadModuleMapFile (#10733)
`loadModuleMapFile` returns true on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value correctly.
1 parent af09a65 commit e3fe1f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
325325
auto file = HS.lookupModuleMapFile(*dir, is_framework);
326326
if (!file)
327327
return error();
328-
if (!HS.loadModuleMapFile(*file, is_system))
328+
if (HS.loadModuleMapFile(*file, is_system))
329329
return error();
330330
}
331331
}

0 commit comments

Comments
 (0)