Fix silent-overwrite behavior of FileManager.copyItem() on Linux

gwynne · web-flow · commit 6aa0ee4266c4 · 2023-09-16T08:12:34.000-05:00
diff --git a/Sources/Foundation/FileManager+POSIX.swift b/Sources/Foundation/FileManager+POSIX.swift
@@ -584,7 +584,7 @@ extension FileManager {
         }
         defer { close(srcfd) }
 
-        let dstfd = open(dstRep, O_WRONLY | O_CREAT | O_TRUNC, 0o666)
+        let dstfd = open(dstRep, O_WRONLY | O_CREAT | O_EXCL | O_TRUNC, 0o666)
         guard dstfd >= 0 else {
             throw _NSErrorWithErrno(errno, reading: false, path: dstPath,
                                     extraUserInfo: extraErrorInfo(srcPath: srcPath, dstPath: dstPath, userVariant: variant))

Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ extension FileManager {`
`584`	`584`	`}`
`585`	`585`	`defer { close(srcfd) }`
`586`	`586`
`587`		`- let dstfd = open(dstRep, O_WRONLY \| O_CREAT \| O_TRUNC, 0o666)`
	`587`	`+ let dstfd = open(dstRep, O_WRONLY \| O_CREAT \| O_EXCL \| O_TRUNC, 0o666)`
`588`	`588`	`guard dstfd >= 0 else {`
`589`	`589`	`throw _NSErrorWithErrno(errno, reading: false, path: dstPath,`
`590`	`590`	`extraUserInfo: extraErrorInfo(srcPath: srcPath, dstPath: dstPath, userVariant: variant))`