exterrnalize metadata and make it version based

motivation: share and scale across multiple platforms

changes:
* introduce location for share metadata
* create metadata file for rpm 5.5.0
* update centos 8 spec and script to use the shared metadata

Author: tomerd

.gitignore

@@ -1,2 +1,2 @@
-.out
+.output
 .DS_Store

platforms/Linux/centos/8/.output/build-output.txt

@@ -8,23 +8,31 @@
 
 #!/usr/bin/env bash
 
-set +ex
+set -ex
 
 OUTDIR=/output
 if [[ ! -d "$OUTDIR" ]]; then
     echo "$OUTDIR does not exist, so no place to copy the artifacts!"
     exit 1
 fi
 
+SWIFT_VERSION=$1
+if [[ ! -n "$SWIFT_VERSION" ]]; then
+    echo "unknown swift version, please pass as argument to the script"
+    exit 1
+fi
+
 # always make sure we're up to date
 yum update -y
 
 # prepare direcoties
 mkdir -p $HOME/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
 
 # Add the spec
-cp swift-lang.spec $HOME/rpmbuild/SPECS/swift-lang.spec
-# Add the patches
+cp swift-lang.spec $HOME/rpmbuild/SPECS/
+# Add the metadata for this swift version
+cp /metadata/rpm/$SWIFT_VERSION/metadata.inc $HOME/rpmbuild/SPECS/
+# Add any patches
 cp patches/*.patch $HOME/rpmbuild/SOURCES/
 
 pushd $HOME/rpmbuild/SPECS

platforms/Linux/centos/8/build_rpm.sh

@@ -21,15 +21,18 @@ services:
     depends_on: [docker-setup]
     volumes:
       - .:/code:z
+      - ../../../../metadata:/metadata:ro
       - ./.output:/output:z
     working_dir: /code
     cap_drop:
       - CAP_NET_RAW
       - CAP_NET_BIND_SERVICE
+    environment:
+      - SWIFT_VERSION # override this with environment variable
 
   build:
     <<: *common
-    command: /bin/bash -cl "./build_rpm.sh"
+    command: /bin/bash -cl "./build_rpm.sh ${SWIFT_VERSION}"
 
   shell:
     <<: *common

platforms/Linux/centos/8/docker-compose.yaml

@@ -1,36 +1,31 @@
+%include metadata.inc
+
 %global debug_package %{nil}
-%global swifttag 5.5-RELEASE
-%global swiftbuild swift-source
-%global icu_version 65-1
-%global yams_version 4.0.2
-%global swift_argument_parser_version 0.4.3
-%global swift_crypto_version 1.1.5
-%global ninja_version 1.10.2
-
-Name:           swift-lang
-Version:        5.5
+
+Name:           %{package_name}
+Version:        %{package_version}
 Release:        1%{?dist}
-Summary:        Apple's Swift programming language
-License:        Apache 2.0
-URL:            https://swift.org
-
-Source0:        https://github.com/apple/swift/archive/swift-%{swifttag}.tar.gz#/swift.tar.gz
-Source1:        https://github.com/apple/swift-corelibs-libdispatch/archive/swift-%{swifttag}.tar.gz#/corelibs-libdispatch.tar.gz
-Source2:        https://github.com/apple/swift-corelibs-foundation/archive/swift-%{swifttag}.tar.gz#/corelibs-foundation.tar.gz
-Source3:        https://github.com/apple/swift-integration-tests/archive/swift-%{swifttag}.tar.gz#/swift-integration-tests.tar.gz
-Source4:        https://github.com/apple/swift-corelibs-xctest/archive/swift-%{swifttag}.tar.gz#/corelibs-xctest.tar.gz
-Source5:        https://github.com/apple/swift-package-manager/archive/swift-%{swifttag}.tar.gz#/package-manager.tar.gz
-Source6:        https://github.com/apple/swift-llbuild/archive/swift-%{swifttag}.tar.gz#/llbuild.tar.gz
-Source7:        https://github.com/apple/swift-cmark/archive/swift-%{swifttag}.tar.gz#/cmark.tar.gz
-Source8:        https://github.com/apple/swift-xcode-playground-support/archive/swift-%{swifttag}.tar.gz#/swift-xcode-playground-support.tar.gz
-Source9:        https://github.com/apple/sourcekit-lsp/archive/swift-%{swifttag}.tar.gz#/sourcekit-lsp.tar.gz
-Source10:       https://github.com/apple/indexstore-db/archive/swift-%{swifttag}.tar.gz#/indexstore-db.tar.gz
-Source11:       https://github.com/apple/llvm-project/archive/swift-%{swifttag}.tar.gz#/llvm-project.tar.gz
-Source12:       https://github.com/apple/swift-tools-support-core/archive/swift-%{swifttag}.tar.gz#/swift-tools-support-core.tar.gz
+Summary:        %{package_summary}
+License:        %{package_license}
+URL:            %{package_url}
+
+Source0:        https://github.com/apple/swift/archive/swift-%{swift_version}.tar.gz#/swift.tar.gz
+Source1:        https://github.com/apple/swift-corelibs-libdispatch/archive/swift-%{swift_version}.tar.gz#/corelibs-libdispatch.tar.gz
+Source2:        https://github.com/apple/swift-corelibs-foundation/archive/swift-%{swift_version}.tar.gz#/corelibs-foundation.tar.gz
+Source3:        https://github.com/apple/swift-integration-tests/archive/swift-%{swift_version}.tar.gz#/swift-integration-tests.tar.gz
+Source4:        https://github.com/apple/swift-corelibs-xctest/archive/swift-%{swift_version}.tar.gz#/corelibs-xctest.tar.gz
+Source5:        https://github.com/apple/swift-package-manager/archive/swift-%{swift_version}.tar.gz#/package-manager.tar.gz
+Source6:        https://github.com/apple/swift-llbuild/archive/swift-%{swift_version}.tar.gz#/llbuild.tar.gz
+Source7:        https://github.com/apple/swift-cmark/archive/swift-%{swift_version}.tar.gz#/cmark.tar.gz
+Source8:        https://github.com/apple/swift-xcode-playground-support/archive/swift-%{swift_version}.tar.gz#/swift-xcode-playground-support.tar.gz
+Source9:        https://github.com/apple/sourcekit-lsp/archive/swift-%{swift_version}.tar.gz#/sourcekit-lsp.tar.gz
+Source10:       https://github.com/apple/indexstore-db/archive/swift-%{swift_version}.tar.gz#/indexstore-db.tar.gz
+Source11:       https://github.com/apple/llvm-project/archive/swift-%{swift_version}.tar.gz#/llvm-project.tar.gz
+Source12:       https://github.com/apple/swift-tools-support-core/archive/swift-%{swift_version}.tar.gz#/swift-tools-support-core.tar.gz
 Source13:       https://github.com/apple/swift-argument-parser/archive/%{swift_argument_parser_version}.tar.gz#/swift-argument-parser.tar.gz
-Source14:       https://github.com/apple/swift-driver/archive/swift-%{swifttag}.tar.gz#/swift-driver.tar.gz
+Source14:       https://github.com/apple/swift-driver/archive/swift-%{swift_version}.tar.gz#/swift-driver.tar.gz
 Source15:       https://github.com/unicode-org/icu/archive/release-%{icu_version}.tar.gz#/icu.tar.gz
-Source16:       https://github.com/apple/swift-syntax/archive/swift-%{swifttag}.zip#/swift-syntax.tar.gz
+Source16:       https://github.com/apple/swift-syntax/archive/swift-%{swift_version}.zip#/swift-syntax.tar.gz
 Source17:       https://github.com/jpsim/Yams/archive/%{yams_version}.zip#/yams.tar.gz
 Source18:       https://github.com/apple/swift-crypto/archive/refs/tags/%{swift_crypto_version}.tar.gz#/swift-crypto.tar.gz
 Source19:       https://github.com/ninja-build/ninja/archive/refs/tags/v%{ninja_version}.tar.gz#/ninja.tar.gz
@@ -96,26 +91,26 @@ importantly, Swift is designed to make writing and maintaining
 correct programs easier for the developer.
 
 %prep
-%setup -q -c -n %{swiftbuild} -a 0 -a 1 -a 2 -a 3 -a 4 -a 5 -a 6 -a 7 -a 8 -a 9 -a 10 -a 11 -a 12 -a 13 -a 14 -a 15 -a 16 -a 17 -a 18 -a 19
+%setup -q -c -n %{swift_source_location} -a 0 -a 1 -a 2 -a 3 -a 4 -a 5 -a 6 -a 7 -a 8 -a 9 -a 10 -a 11 -a 12 -a 13 -a 14 -a 15 -a 16 -a 17 -a 18 -a 19
 # The Swift build script requires directories to be named
 # in a specific way so renaming the source directories is
 # necessary
-mv swift-cmark-swift-%{swifttag} cmark
-mv swift-corelibs-foundation-swift-%{swifttag} swift-corelibs-foundation
-mv swift-corelibs-libdispatch-swift-%{swifttag} swift-corelibs-libdispatch
-mv swift-corelibs-xctest-swift-%{swifttag} swift-corelibs-xctest
-mv swift-integration-tests-swift-%{swifttag} swift-integration-tests
-mv swift-llbuild-swift-%{swifttag} llbuild
-mv swift-package-manager-swift-%{swifttag} swiftpm
-mv swift-swift-%{swifttag} swift
-mv swift-xcode-playground-support-swift-%{swifttag} swift-xcode-playground-support
-mv sourcekit-lsp-swift-%{swifttag} sourcekit-lsp
-mv indexstore-db-swift-%{swifttag} indexstore-db
-mv llvm-project-swift-%{swifttag} llvm-project
-mv swift-syntax-swift-%{swifttag} swift-syntax
-mv swift-tools-support-core-swift-%{swifttag} swift-tools-support-core
+mv swift-cmark-swift-%{swift_version} cmark
+mv swift-corelibs-foundation-swift-%{swift_version} swift-corelibs-foundation
+mv swift-corelibs-libdispatch-swift-%{swift_version} swift-corelibs-libdispatch
+mv swift-corelibs-xctest-swift-%{swift_version} swift-corelibs-xctest
+mv swift-integration-tests-swift-%{swift_version} swift-integration-tests
+mv swift-llbuild-swift-%{swift_version} llbuild
+mv swift-package-manager-swift-%{swift_version} swiftpm
+mv swift-swift-%{swift_version} swift
+mv swift-xcode-playground-support-swift-%{swift_version} swift-xcode-playground-support
+mv sourcekit-lsp-swift-%{swift_version} sourcekit-lsp
+mv indexstore-db-swift-%{swift_version} indexstore-db
+mv llvm-project-swift-%{swift_version} llvm-project
+mv swift-syntax-swift-%{swift_version} swift-syntax
+mv swift-tools-support-core-swift-%{swift_version} swift-tools-support-core
 mv swift-argument-parser-%{swift_argument_parser_version} swift-argument-parser
-mv swift-driver-swift-%{swifttag} swift-driver
+mv swift-driver-swift-%{swift_version} swift-driver
 mv swift-crypto-%{swift_crypto_version} swift-crypto
 mv ninja-%{ninja_version} ninja