Skip to content

Commit 5d70eb6

Browse files
committed
WiX: shuffle around non-llbuild components
Move the import libraries for other components into the appropriate component groups. This cleans up the llbuild component.
1 parent 4c8c80a commit 5d70eb6

File tree

2 files changed

+28
-24
lines changed

2 files changed

+28
-24
lines changed

platforms/Windows/toolchain-amd64.wxs

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,11 @@
495495
<File Id="BlocksRuntime.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\BlocksRuntime.dll" Checksum="yes" />
496496
</Component>
497497

498-
<!-- TODO(compnerd) should we install the block headers and import libraries? -->
498+
<Component Id="BlocksRuntime.lib" Directory="_usr_lib" Guid="b758a96a-644b-421d-a668-2ba2b55601aa">
499+
<File Id="BlocksRuntime.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\BlocksRuntime.lib" Checksum="yes" />
500+
</Component>
501+
502+
<!-- TODO(compnerd) should we install the block headers? -->
499503
</ComponentGroup>
500504

501505
<?ifdef INCLUDE_DEBUG_INFO ?>
@@ -511,7 +515,11 @@
511515
<File Id="dispatch.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\dispatch.dll" Checksum="yes" />
512516
</Component>
513517

514-
<!-- TODO(compnerd) should we install the dispatch headers and import libraries? -->
518+
<Component Id="dispatch.lib" Directory="_usr_lib" Guid="b5d342d2-fc9a-46e5-93ac-1781e2055ac4">
519+
<File Id="dispatch.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\dispatch.lib" Checksum="yes" />
520+
</Component>
521+
522+
<!-- TODO(compnerd) should we install the dispatch headers? -->
515523
</ComponentGroup>
516524

517525
<?ifdef INCLUDE_DEBUG_INFO ?>
@@ -527,6 +535,10 @@
527535
<File Id="sourcekitdInProc.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\sourcekitdInProc.dll" Checksum="yes" />
528536
</Component>
529537

538+
<Component Id="sourcekitdInProc.lib" Directory="_usr_lib" Guid="cd564210-c471-478e-b1c4-d6a35fc6572f">
539+
<File Id="sourcekitdInProc.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\sourcekitdInProc.lib" Checksum="yes" />
540+
</Component>
541+
530542
<Component Id="sourcekitd.h" Directory="_usr_include_SourceKit" Guid="bdb02d6c-b3f7-4109-bd41-fc04734484a4">
531543
<File Id="sourcekitd.h" Source="$(var.TOOLCHAIN_ROOT)\usr\include\SourceKit\sourcekitd.h" Checksum="yes" />
532544
</Component>
@@ -648,16 +660,6 @@
648660
<Component Id="llbuildSwift.dll" Directory="_usr_bin" Guid="4386ca67-150b-424f-a699-7029f41746d5">
649661
<File Id="llbuildSwift.dll" Source="$(var.DEVTOOLS_ROOT)\usr\bin\llbuildSwift.dll" Checksum="yes" />
650662
</Component>
651-
652-
<Component Id="BlocksRuntime.lib" Directory="_usr_lib" Guid="b758a96a-644b-421d-a668-2ba2b55601aa">
653-
<File Id="BlocksRuntime.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\BlocksRuntime.lib" Checksum="yes" />
654-
</Component>
655-
<Component Id="dispatch.lib" Directory="_usr_lib" Guid="b5d342d2-fc9a-46e5-93ac-1781e2055ac4">
656-
<File Id="dispatch.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\dispatch.lib" Checksum="yes" />
657-
</Component>
658-
<Component Id="sourcekitdInProc.lib" Directory="_usr_lib" Guid="cd564210-c471-478e-b1c4-d6a35fc6572f">
659-
<File Id="sourcekitdInProc.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\sourcekitdInProc.lib" Checksum="yes" />
660-
</Component>
661663
</ComponentGroup>
662664

663665
<?ifdef INCLUDE_DEBUG_INFO ?>

platforms/Windows/toolchain-arm64.wxs

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,11 @@
495495
<File Id="BlocksRuntime.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\BlocksRuntime.dll" Checksum="yes" />
496496
</Component>
497497

498-
<!-- TODO(compnerd) should we install the block headers and import libraries? -->
498+
<Component Id="BlocksRuntime.lib" Directory="_usr_lib" Guid="33221a05-d071-432c-b9a1-196b14d2ea19">
499+
<File Id="BlocksRuntime.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\BlocksRuntime.lib" Checksum="yes" />
500+
</Component>
501+
502+
<!-- TODO(compnerd) should we install the block headers? -->
499503
</ComponentGroup>
500504

501505
<?ifdef INCLUDE_DEBUG_INFO ?>
@@ -511,7 +515,11 @@
511515
<File Id="dispatch.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\dispatch.dll" Checksum="yes" />
512516
</Component>
513517

514-
<!-- TODO(compnerd) should we install the dispatch headers and import libraries? -->
518+
<Component Id="dispatch.lib" Directory="_usr_lib" Guid="5a001bb8-4557-41eb-8d2d-38870cd2e9dc">
519+
<File Id="dispatch.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\dispatch.lib" Checksum="yes" />
520+
</Component>
521+
522+
<!-- TODO(compnerd) should we install the dispatch headers? -->
515523
</ComponentGroup>
516524

517525
<?ifdef INCLUDE_DEBUG_INFO ?>
@@ -527,6 +535,10 @@
527535
<File Id="sourcekitdInProc.dll" Source="$(var.TOOLCHAIN_ROOT)\usr\bin\sourcekitdInProc.dll" Checksum="yes" />
528536
</Component>
529537

538+
<Component Id="sourcekitdInProc.lib" Directory="_usr_lib" Guid="f95bebbf-15ec-4cd5-9d1f-dd831ce34a9d">
539+
<File Id="sourcekitdInProc.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\sourcekitdInProc.lib" Checksum="yes" />
540+
</Component>
541+
530542
<Component Id="sourcekitd.h" Directory="_usr_include_SourceKit" Guid="bdb02d6c-b3f7-4109-bd41-fc04734484a4">
531543
<File Id="sourcekitd.h" Source="$(var.TOOLCHAIN_ROOT)\usr\include\SourceKit\sourcekitd.h" Checksum="yes" />
532544
</Component>
@@ -648,16 +660,6 @@
648660
<Component Id="llbuildSwift.dll" Directory="_usr_bin" Guid="93fd1e4e-7b70-4440-93fb-0889e50840f3">
649661
<File Id="llbuildSwift.dll" Source="$(var.DEVTOOLS_ROOT)\usr\bin\llbuildSwift.dll" Checksum="yes" />
650662
</Component>
651-
652-
<Component Id="BlocksRuntime.lib" Directory="_usr_lib" Guid="33221a05-d071-432c-b9a1-196b14d2ea19">
653-
<File Id="BlocksRuntime.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\BlocksRuntime.lib" Checksum="yes" />
654-
</Component>
655-
<Component Id="dispatch.lib" Directory="_usr_lib" Guid="5a001bb8-4557-41eb-8d2d-38870cd2e9dc">
656-
<File Id="dispatch.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\dispatch.lib" Checksum="yes" />
657-
</Component>
658-
<Component Id="sourcekitdInProc.lib" Directory="_usr_lib" Guid="f95bebbf-15ec-4cd5-9d1f-dd831ce34a9d">
659-
<File Id="sourcekitdInProc.lib" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\sourcekitdInProc.lib" Checksum="yes" />
660-
</Component>
661663
</ComponentGroup>
662664

663665
<?ifdef INCLUDE_DEBUG_INFO ?>

0 commit comments

Comments
 (0)