NFC: Add a test-case for -w in clang arguments for "remote" packages

Remote in this case means local or remote source control or registry.

Author: xedin

Tests/BuildTests/ClangTargetBuildDescriptionTests.swift

@@ -22,6 +22,7 @@ final class ClangTargetBuildDescriptionTests: XCTestCase {
     func testClangIndexStorePath() throws {
         let targetDescription = try makeTargetBuildDescription("test")
         XCTAssertTrue(try targetDescription.basicArguments().contains("-index-store-path"))
+        XCTAssertFalse(try targetDescription.basicArguments().contains("-w"))
     }
 
     func testSwiftCorelibsFoundationIncludeWorkaround() throws {
@@ -45,6 +46,11 @@ final class ClangTargetBuildDescriptionTests: XCTestCase {
         XCTAssertTrue(try androidDescription.basicArguments().contains("\(androidParameters.toolchain.swiftResourcesPath!)"))
     }
 
+    func testWarningSuppressionForRemotePackages() throws {
+        let targetDescription = try makeTargetBuildDescription("test-warning-supression", usesSourceControl: true)
+        XCTAssertTrue(try targetDescription.basicArguments().contains("-w"))
+    }
+
     private func makeClangTarget() throws -> ClangTarget {
         try ClangTarget(
             name: "dummy",
@@ -70,14 +76,20 @@ final class ClangTargetBuildDescriptionTests: XCTestCase {
     }
 
     private func makeTargetBuildDescription(_ packageName: String,
-                                            buildParameters: BuildParameters? = nil) throws -> ClangTargetBuildDescription {
+                                            buildParameters: BuildParameters? = nil,
+                                            usesSourceControl: Bool = false) throws -> ClangTargetBuildDescription {
         let observability = ObservabilitySystem.makeForTesting(verbose: false)
 
-        let manifest = Manifest.createRootManifest(
-            displayName: "dummy",
-            toolsVersion: .v5,
-            targets: [try TargetDescription(name: "dummy")]
-        )
+        let manifest: Manifest
+        if usesSourceControl {
+            manifest = Manifest.createLocalSourceControlManifest(
+                displayName: packageName, path: AbsolutePath("/\(packageName)"))
+        } else {
+            manifest = Manifest.createRootManifest(
+                displayName: packageName,
+                toolsVersion: .v5,
+                targets: [try TargetDescription(name: "dummy")])
+        }
 
         let target = try makeResolvedTarget()