[6.0] Fix cache not cleaned up if download fails (#7671)

Cherry-pick of #7663.

**Explanation**: If a server returns an error when trying to download a
binaryTarget an invalid file remains in the artifacts cache.
**Scope**: Isolated to binary targets cache.
**Risk**: Low, scope is isolated, and the change has a corresponding
test.
**Testing**: Automated with an existing test case refined.
**Issue**: rdar://123897276
**Reviewer**: @MaxDesiatov

---------

Co-authored-by: Philipp Wallrich <[email protected]>

Author: MaxDesiatov

Sources/SPMTestSupport/MockWorkspace.swift

@@ -136,6 +136,10 @@ public final class MockWorkspace {
         return self.sandbox.appending(components: ".build", "artifacts")
     }
 
+    public var workspaceLocation: Workspace.Location? {
+        return self._workspace?.location
+    }
+
     public func pathToRoot(withName name: String) throws -> AbsolutePath {
         return try AbsolutePath(validating: name, relativeTo: self.rootsDir)
     }

Sources/Workspace/Workspace+BinaryArtifacts.swift

@@ -618,6 +618,9 @@ extension Workspace {
                 progress: progress,
                 completion: { result in
                     self.delegate?.willDownloadBinaryArtifact(from: artifact.url.absoluteString, fromCache: false)
+                    if case .failure = result {
+                        try? self.fileSystem.removeFileTree(cachedArtifactPath)
+                    }
                     completion(result.flatMap {
                         Result.init(catching: {
                             // copy from cache to destination

Tests/WorkspaceTests/WorkspaceTests.swift

@@ -7374,6 +7374,7 @@ final class WorkspaceTests: XCTestCase {
         let fs = InMemoryFileSystem()
         let sandbox = AbsolutePath("/tmp/ws/")
         try fs.createDirectory(sandbox, recursive: true)
+        let artifactUrl = "https://a.com/a.zip"
 
         let httpClient = LegacyHTTPClient(handler: { request, _, completion in
             do {
@@ -7404,7 +7405,7 @@ final class WorkspaceTests: XCTestCase {
                         MockTarget(
                             name: "A1",
                             type: .binary,
-                            url: "https://a.com/a.zip",
+                            url: artifactUrl,
                             checksum: "a1"
                         ),
                     ]
@@ -7429,6 +7430,17 @@ final class WorkspaceTests: XCTestCase {
         // make sure artifact downloaded is deleted
         XCTAssertTrue(fs.isDirectory(AbsolutePath("/tmp/ws/.build/artifacts/root")))
         XCTAssertFalse(fs.exists(AbsolutePath("/tmp/ws/.build/artifacts/root/a.zip")))
+
+        // make sure the cached artifact is also deleted
+        let artifactCacheKey = artifactUrl.spm_mangledToC99ExtendedIdentifier()
+        guard let cachePath = workspace.workspaceLocation?
+            .sharedBinaryArtifactsCacheDirectory?
+            .appending(artifactCacheKey) else {
+            XCTFail("Required workspace location wasn't found")
+            return
+        }
+
+        XCTAssertFalse(fs.exists(cachePath))
     }
 
     func testArtifactDownloaderOrArchiverError() throws {