Fix build of host&target destination products with --static-swift-stdlib

Given the following conditions:
- `--static-swift-stdlib` is enabled (it only affects "target" destination
  products, "host" destination products are always dynamic)
- the building subset contains both "host" and "target" destination products
  derived from the same product.
- the product imports `Foundation` (that has private dependency libs)

then the build randomly failed due to the race condition of the
Objects.LinkFileList creation.

This commit fixes the issue by distinguishing the temporary link file
list response file name by the `-tool` suffix.

Author: kateinoigakukun

Sources/Build/BuildDescription/ProductBuildDescription.swift

@@ -66,7 +66,8 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
 
     /// Path to the temporary directory for this product.
     var tempsPath: AbsolutePath {
-        self.buildParameters.buildPath.appending(component: self.product.name + ".product")
+        let suffix = buildParameters.suffix
+        return self.buildParameters.buildPath.appending(component: "\(self.product.name)\(suffix).product")
     }
 
     /// Path to the link filelist file.

Tests/CommandsTests/PackageCommandTests.swift

@@ -1574,6 +1574,14 @@ final class PackageCommandTests: CommandsTestCase {
     }
 
     func testBuildToolPlugin() throws {
+        try testBuildToolPlugin(staticStdlib: false)
+    }
+
+    func testBuildToolPluginWithStaticStdlib() throws {
+        try testBuildToolPlugin(staticStdlib: true)
+    }
+
+    func testBuildToolPlugin(staticStdlib: Bool) throws {
         // Only run the test if the environment in which we're running actually supports Swift concurrency (which the plugin APIs require).
         try XCTSkipIf(!UserToolchain.default.supportsSwiftConcurrency(), "skipping because test environment doesn't support concurrency")
 
@@ -1647,7 +1655,8 @@ final class PackageCommandTests: CommandsTestCase {
             )
 
             // Invoke it, and check the results.
-            let (stdout, stderr) = try SwiftPM.Build.execute(packagePath: packageDir)
+            let args = staticStdlib ? ["--static-swift-stdlib"] : []
+            let (stdout, stderr) = try SwiftPM.Build.execute(args, packagePath: packageDir)
             XCTAssert(stdout.contains("Build complete!"))
 
             // We expect a warning about `library.bar` but not about `library.foo`.