Reenable disabled tests (#5957)

* Revert "Pass `SWIFT_EXEC` to swift-test via bootstrap (#4213)"
* Revert "Disable `FunctionalTests` temporarily (#5875)"
* Reenable disabled tests

These tests were disabled but proven working again.

rdar://101868275

Author: neonichu

Package.swift

@@ -507,8 +507,7 @@ let package = Package(
             name: "WorkspaceTests",
             dependencies: ["Workspace", "SPMTestSupport"]
         ),
-        // rdar://101868275 "error: cannot find 'XCTAssertEqual' in scope" can affect almost any functional test, so we flat out disable them all until we know what is going on
-        /*.testTarget(
+        .testTarget(
             name: "FunctionalTests",
             dependencies: [
                 "swift-build",
@@ -517,7 +516,7 @@ let package = Package(
                 "PackageModel",
                 "SPMTestSupport"
             ]
-        ),*/
+        ),
         .testTarget(
             name: "FunctionalPerformanceTests",
             dependencies: [

Tests/CommandsTests/BuildToolTests.swift

@@ -280,7 +280,7 @@ final class BuildToolTests: CommandsTestCase {
     }
 
     func testBuildCompleteMessage() throws {
-        throw XCTSkip("This test fails to match the 'Compiling' regex; rdar://101815761")
+        throw XCTSkip("This test isn't stable w.r.t. the build cache; rdar://101815761")
 
         try fixture(name: "DependencyResolution/Internal/Simple") { fixturePath in
             do {

Tests/FunctionalTests/PluginTests.swift

@@ -461,6 +461,7 @@ class PluginTests: XCTestCase {
                         outputDirectory: pluginDir.appending(component: "output"),
                         toolSearchDirectories: toolSearchDirectories,
                         toolNamesToPaths: [:],
+                        toolNamesToTriples: [:],
                         writableDirectories: [pluginDir.appending(component: "output")],
                         readOnlyDirectories: [package.path],
                         fileSystem: localFileSystem,
@@ -722,6 +723,7 @@ class PluginTests: XCTestCase {
                 outputDirectory: pluginDir.appending(component: "output"),
                 toolSearchDirectories: [try UserToolchain.default.swiftCompilerPath.parentDirectory],
                 toolNamesToPaths: [:],
+                toolNamesToTriples: [:],
                 writableDirectories: [pluginDir.appending(component: "output")],
                 readOnlyDirectories: [package.path],
                 fileSystem: localFileSystem,

Tests/WorkspaceTests/InitTests.swift

@@ -266,8 +266,6 @@ class InitTests: XCTestCase {
     }
 
     func testNonC99NameExecutablePackage() throws {
-        throw XCTSkip("This test fails to find XCTAssertEqual; rdar://101868275")
-
         try withTemporaryDirectory(removeTreeOnDeinit: true) { tempDirPath in
             XCTAssertDirectoryExists(tempDirPath)
 

Tests/WorkspaceTests/WorkspaceTests.swift

@@ -4291,8 +4291,6 @@ final class WorkspaceTests: XCTestCase {
 
     // This verifies that the simplest possible loading APIs are available for package clients.
     func testSimpleAPI() throws {
-        throw XCTSkip("This test fails to find XCTAssertEqual; rdar://101868275")
-
         try testWithTemporaryDirectory { path in
             // Create a temporary package as a test case.
             let packagePath = path.appending(component: "MyPkg")

Utilities/bootstrap

@@ -361,11 +361,7 @@ def test(args):
 
     note("Testing")
     parse_test_args(args)
-    cmd = [
-        "SWIFT_EXEC=" + args.swiftc_path,
-        "SWIFT_DRIVER_SWIFT_EXEC=" + args.swiftc_path,
-        os.path.join(args.bin_dir, "swift-test")
-    ]
+    cmd = [os.path.join(args.bin_dir, "swift-test")]
     if args.parallel:
         cmd.append("--parallel")
     for arg in args.filter: