Skip to content

Commit dca0cc2

Browse files
authored
Tests: Disable assert in TraitTests (#8132)
Disable assertion in `TraitTests`, which was never executed on macOS due to the self-hosted macOS pipeline running Swift 5.9..2, and test being wrapped around `#if compiler(>=6.0)` pre-processor. ### Motivation: The assertion in `TraitTets` that ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work. This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed. ### Modifications: Disabled assertion the the `TraitTests` ### Result: ``` swift test --filter "TraitTests" ``` ### NOTE: It is expected the assertions will be re-introduced when #8131 is fixed.
1 parent 4c206fb commit dca0cc2

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

Tests/FunctionalTests/TraitTests.swift

+16-8
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ final class TraitTests: XCTestCase {
2121
try await fixture(name: "Traits") { fixturePath in
2222
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example")
2323
// We expect no warnings to be produced. Specifically no unused dependency warnings.
24-
XCTAssertFalse(stderr.contains("warning:"))
24+
// When fixed, GitHub issue #8131 should re-enable the below assert.
25+
// XCTAssertFalse(stderr.contains("warning:"))
2526
XCTAssertEqual(stdout, """
2627
Package1Library1 trait1 enabled
2728
Package2Library1 trait2 enabled
@@ -39,7 +40,8 @@ final class TraitTests: XCTestCase {
3940
try await fixture(name: "Traits") { fixturePath in
4041
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-traits", "default,Package9,Package10"])
4142
// We expect no warnings to be produced. Specifically no unused dependency warnings.
42-
XCTAssertFalse(stderr.contains("warning:"))
43+
// When fixed, GitHub issue #8131 should re-enable the below assert.
44+
// XCTAssertFalse(stderr.contains("warning:"))
4345
XCTAssertEqual(stdout, """
4446
Package1Library1 trait1 enabled
4547
Package2Library1 trait2 enabled
@@ -61,7 +63,8 @@ final class TraitTests: XCTestCase {
6163
try await fixture(name: "Traits") { fixturePath in
6264
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-traits", "default,Package9"])
6365
// We expect no warnings to be produced. Specifically no unused dependency warnings.
64-
XCTAssertFalse(stderr.contains("warning:"))
66+
// When fixed, GitHub issue #8131 should re-enable the below assert.
67+
// XCTAssertFalse(stderr.contains("warning:"))
6568
XCTAssertEqual(stdout, """
6669
Package1Library1 trait1 enabled
6770
Package2Library1 trait2 enabled
@@ -81,7 +84,8 @@ final class TraitTests: XCTestCase {
8184
try await fixture(name: "Traits") { fixturePath in
8285
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-traits", "default,Package5,Package7,BuildCondition3"])
8386
// We expect no warnings to be produced. Specifically no unused dependency warnings.
84-
XCTAssertFalse(stderr.contains("warning:"))
87+
// When fixed, GitHub issue #8131 should re-enable the below assert.
88+
// XCTAssertFalse(stderr.contains("warning:"))
8589
XCTAssertEqual(stdout, """
8690
Package1Library1 trait1 enabled
8791
Package2Library1 trait2 enabled
@@ -102,7 +106,8 @@ final class TraitTests: XCTestCase {
102106
try await fixture(name: "Traits") { fixturePath in
103107
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-disable-default-traits"])
104108
// We expect no warnings to be produced. Specifically no unused dependency warnings.
105-
XCTAssertFalse(stderr.contains("warning:"))
109+
// When fixed, GitHub issue #8131 should re-enable the below assert.
110+
// XCTAssertFalse(stderr.contains("warning:"))
106111
XCTAssertEqual(stdout, """
107112
DEFINE1 disabled
108113
DEFINE2 disabled
@@ -116,7 +121,8 @@ final class TraitTests: XCTestCase {
116121
try await fixture(name: "Traits") { fixturePath in
117122
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-traits", "Package5,Package7"])
118123
// We expect no warnings to be produced. Specifically no unused dependency warnings.
119-
XCTAssertFalse(stderr.contains("warning:"))
124+
// When fixed, GitHub issue #8131 should re-enable the below assert.
125+
// XCTAssertFalse(stderr.contains("warning:"))
120126
XCTAssertEqual(stdout, """
121127
Package5Library1 trait1 enabled
122128
Package6Library1 trait1 enabled
@@ -133,7 +139,8 @@ final class TraitTests: XCTestCase {
133139
try await fixture(name: "Traits") { fixturePath in
134140
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-enable-all-traits"])
135141
// We expect no warnings to be produced. Specifically no unused dependency warnings.
136-
XCTAssertFalse(stderr.contains("warning:"))
142+
// GitHub issue #8131
143+
// XCTAssertFalse(stderr.contains("warning:"))
137144
XCTAssertEqual(stdout, """
138145
Package1Library1 trait1 enabled
139146
Package2Library1 trait2 enabled
@@ -158,7 +165,8 @@ final class TraitTests: XCTestCase {
158165
try await fixture(name: "Traits") { fixturePath in
159166
let (stdout, stderr) = try await executeSwiftRun(fixturePath.appending("Example"), "Example", extraArgs: ["--experimental-enable-all-traits", "--experimental-disable-default-traits"])
160167
// We expect no warnings to be produced. Specifically no unused dependency warnings.
161-
XCTAssertFalse(stderr.contains("warning:"))
168+
// GitHub issue #8131
169+
// XCTAssertFalse(stderr.contains("warning:"))
162170
XCTAssertEqual(stdout, """
163171
Package1Library1 trait1 enabled
164172
Package2Library1 trait2 enabled

0 commit comments

Comments
 (0)