Don't need to set HANDLE_FLAG_INHERIT

grynspan · grynspan · commit 4b4ec43e8212 · 2024-09-16T23:11:51.000-04:00
diff --git a/Sources/Testing/ExitTests/SpawnProcess.swift b/Sources/Testing/ExitTests/SpawnProcess.swift
@@ -141,9 +141,6 @@ func spawnExecutable(
         guard let handle else {
           throw SystemError(description: "A child process inherit a file handle without an associated Windows handle. Please file a bug report at https://github.com/swiftlang/swift-testing/issues/new")
         }
-        guard SetHandleInformation(handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT) else {
-          throw Win32Error(rawValue: GetLastError())
-        }
         inheritedHandlesBuffer[i] = handle
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -141,9 +141,6 @@ func spawnExecutable(`
`141`	`141`	`guard let handle else {`
`142`	`142`	`throw SystemError(description: "A child process inherit a file handle without an associated Windows handle. Please file a bug report at https://github.com/swiftlang/swift-testing/issues/new")`
`143`	`143`	`}`
`144`		`- guard SetHandleInformation(handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT) else {`
`145`		`- throw Win32Error(rawValue: GetLastError())`
`146`		`- }`
`147`	`144`	`inheritedHandlesBuffer[i] = handle`
`148`	`145`	`}`
`149`	`146`	`}`