Use URL.resourceValues() for symlink detection

neonichu · pyrtsa · neonichu · commit 0eff15a25f66 · 2023-08-14T13:20:18.000-07:00
This should provide a significant performance improvement on macOS. See [https://github.com/apple/swift-tools-support-core/pull/400#issuecomment-1618933610](this) for more discussion on non-macOS platforms. Co-authored-by: Pyry Jahkola <pyry.jahkola@iki.fi>
diff --git a/Sources/TSCBasic/FileSystem.swift b/Sources/TSCBasic/FileSystem.swift
@@ -370,8 +370,9 @@ private struct LocalFileSystem: FileSystem {
     }
 
     func isSymlink(_ path: AbsolutePath) -> Bool {
-        let attrs = try? FileManager.default.attributesOfItem(atPath: path.pathString)
-        return attrs?[.type] as? FileAttributeType == .typeSymbolicLink
+        let url = NSURL(fileURLWithPath: path.pathString)
+        let result = try? url.resourceValues(forKeys: [.isSymbolicLinkKey])
+        return (result?[.isSymbolicLinkKey] as? Bool) == true
     }
 
     func isReadable(_ path: AbsolutePath) -> Bool {

Original file line number	Diff line number	Diff line change
`@@ -370,8 +370,9 @@ private struct LocalFileSystem: FileSystem {`
`370`	`370`	`}`
`371`	`371`
`372`	`372`	`func isSymlink(_ path: AbsolutePath) -> Bool {`
`373`		`- let attrs = try? FileManager.default.attributesOfItem(atPath: path.pathString)`
`374`		`- return attrs?[.type] as? FileAttributeType == .typeSymbolicLink`
	`373`	`+ let url = NSURL(fileURLWithPath: path.pathString)`
	`374`	`+ let result = try? url.resourceValues(forKeys: [.isSymbolicLinkKey])`
	`375`	`+ return (result?[.isSymbolicLinkKey] as? Bool) == true`
`375`	`376`	`}`
`376`	`377`
`377`	`378`	`func isReadable(_ path: AbsolutePath) -> Bool {`