Added tests for let properties to Mirror

Author: nickolas-pohilets

test/stdlib/WeakMirror.swift

@@ -14,9 +14,9 @@
 // RUN: if [ %target-runtime == "objc" ]; \
 // RUN: then \
 // RUN:   %target-clang %S/Inputs/Mirror/Mirror.mm -c -o %t/Mirror.mm.o -g && \
-// RUN:   %target-build-swift -Xfrontend -disable-access-control %s -I %S/Inputs/Mirror/ -Xlinker %t/Mirror.mm.o -o %t/Mirror; \
+// RUN:   %target-build-swift -Xfrontend -disable-access-control -Xfrontend -enable-experimental-feature -Xfrontend WeakLet %s -I %S/Inputs/Mirror/ -Xlinker %t/Mirror.mm.o -o %t/Mirror; \
 // RUN: else \
-// RUN:   %target-build-swift %s -Xfrontend -disable-access-control -o %t/Mirror; \
+// RUN:   %target-build-swift %s -Xfrontend -disable-access-control -Xfrontend -enable-experimental-feature -Xfrontend WeakLet -o %t/Mirror; \
 // RUN: fi
 // RUN: %target-codesign %t/Mirror
 // RUN: %target-run %t/Mirror
@@ -123,6 +123,91 @@ mirrors.test("class/NativeSwiftClassHasNativeWeakReferenceNoLeak") {
   expectNil(verifier)
 }
 
+#if hasFeature(WeakLet)
+class NativeSwiftClassHasWeakLet {
+  weak let weakProperty: AnyObject?
+  let x: Int
+  init(x: Int, weakProperty: AnyObject?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+class NativeSwiftClassHasNativeClassBoundExistentialLet {
+  weak let weakProperty: NativeClassBoundExistential?
+  let x: Int
+  init(x: Int, weakProperty: NativeClassBoundExistential?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+struct StructHasNativeWeakLetReference {
+  weak let weakProperty: AnyObject?
+  let x: Int
+  init(x: Int, weakProperty: AnyObject?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+mirrors.test("class/NativeSwiftClassHasNativeWeakLetReference") {
+  let child = NativeSwiftClass(x: 2020)
+  let parent = NativeSwiftClassHasWeakLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! NativeSwiftClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/NativeSwiftClassHasNativeClassBoundExistentialLet") {
+  let child = NativeSwiftClass(x: 2020) as NativeClassBoundExistential
+  let parent = NativeSwiftClassHasNativeClassBoundExistentialLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! NativeSwiftClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("struct/StructHasNativeWeakLetReference") {
+  let child = NativeSwiftClass(x: 2020)
+  var parent = StructHasNativeWeakLetReference(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! NativeSwiftClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+// https://github.com/apple/swift/issues/51384
+// Using 'Mirror' to access a weak reference results in object being
+// retained indefinitely
+mirrors.test("class/NativeSwiftClassHasNativeWeakLetReferenceNoLeak") {
+  weak var verifier: AnyObject?
+  do {
+    let child = NativeSwiftClass(x: 2020)
+    verifier = child
+    let parent = NativeSwiftClassHasWeakLet(x: 1010, weakProperty: child)
+    let mirror = Mirror(reflecting: parent)
+    let children = Array(mirror.children)
+    let extractedChild = children[0].1 as! NativeSwiftClass
+    expectNotNil(extractedChild)
+    expectNotNil(verifier)
+    // If child is destroyed, the above cast and checks will fail.
+    _fixLifetime(child)
+  }
+  expectNil(verifier)
+}
+#endif
+
 #if _runtime(_ObjC)
 
 import Foundation
@@ -292,6 +377,160 @@ mirrors.test("struct/StructHasObjCClassBoundExistential") {
   print(extractedChild)
 }
 
+#if hasFeature(WeakLet)
+
+class NativeSwiftClassHasObjCClassBoundExistentialLet {
+  weak let weakProperty: ObjCClassExistential?
+  let x: Int
+  init(x: Int, weakProperty: ObjCClassExistential?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+class ObjCClassHasWeakLet : NSObject {
+  weak let weakProperty: AnyObject?
+  let x: Int
+  init(x: Int, weakProperty: AnyObject?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+class ObjCClassHasNativeClassBoundExistentialLet : NSObject {
+  weak let weakProperty: NativeClassBoundExistential?
+  let x: Int
+  init(x: Int, weakProperty: NativeClassBoundExistential?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+class ObjCClassHasObjCClassBoundExistentialLet : NSObject {
+  weak let weakProperty: ObjCClassExistential?
+  let x: Int
+  init(x: Int, weakProperty: ObjCClassExistential?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+struct StructHasObjCWeakLetReference {
+  weak let weakProperty: ObjCClass?
+  let x: Int
+  init(x: Int, weakProperty: ObjCClass?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+struct StructHasObjCClassBoundExistentialLet {
+  weak let weakProperty: ObjCClassExistential?
+  let x: Int
+  init(x: Int, weakProperty: ObjCClassExistential?) {
+    self.x = x
+    self.weakProperty = weakProperty
+  }
+}
+
+mirrors.test("class/NativeSwiftClassHasObjCWeakLetReference") {
+  let child = ObjCClass(x: 2020)
+  let parent = NativeSwiftClassHasWeakLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/NativeSwiftClassHasObjCClassBoundExistentialLet") {
+  let child = ObjCClass(x: 2020) as ObjCClassExistential
+  let parent = NativeSwiftClassHasObjCClassBoundExistentialLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/ObjCClassHasNativeWeakLet") {
+  let child = NativeSwiftClass(x: 2020)
+  let parent = ObjCClassHasWeakLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! NativeSwiftClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/ObjcCClassHasObjCWeakLetReference") {
+  let child = ObjCClass(x: 2020)
+  let parent = ObjCClassHasWeakLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/ObjCClassHasNativeClassBoundExistentialLet") {
+  let child = NativeSwiftClass(x: 2020) as NativeClassBoundExistential
+  let parent = ObjCClassHasNativeClassBoundExistentialLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! NativeSwiftClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("class/ObjCClassHasObjCClassBoundExistentialLet") {
+  let child = ObjCClass(x: 2020) as ObjCClassExistential
+  let parent = ObjCClassHasObjCClassBoundExistentialLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("struct/StructHasObjCWeakLetReference") {
+  let child = ObjCClass(x: 2020)
+  var parent = StructHasObjCWeakLetReference(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+mirrors.test("struct/StructHasObjCClassBoundExistentialLet") {
+  let child = ObjCClass(x: 2020) as ObjCClassExistential
+  var parent = StructHasObjCClassBoundExistentialLet(x: 1010, weakProperty: child)
+  let mirror = Mirror(reflecting: parent)
+  let children = Array(mirror.children)
+  let extractedChild = children[0].1 as! ObjCClass
+  expectNotEqual(parent.x, extractedChild.x)
+  expectEqual(ObjectIdentifier(child), ObjectIdentifier(extractedChild))
+  expectEqual(child.x, extractedChild.x)
+  print(extractedChild)
+}
+
+#endif
+
 #endif
 
 runAllTests()