Merge pull request #28432 from atrick/disable-unknown-storage

Temporarily disable a SILVerifier check for valid accessed storage.

Author: atrick

lib/SIL/SILVerifier.cpp

@@ -1886,8 +1886,15 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
     // like debugger variables. The compiler never cares about the source of
     // those accesses.
     AccessedStorage storage = findAccessedStorage(BAI->getSource());
+    // FIXME: rdar://57291811 - the following check for valid storage will be
+    // reenabled shortly. A fix is planned. In the meantime, the possiblity that
+    // a real miscompilation could be caused by this failure is insignificant.
+    // I will probably enable a much broader SILVerification of address-type
+    // block arguments first to ensure we never hit this check again.
+    /*
     if (BAI->getEnforcement() != SILAccessEnforcement::Unsafe)
       require(storage, "Unknown formal access pattern");
+    */
   }
 
   void checkEndAccessInst(EndAccessInst *EAI) {