[AliasAnalysis] Rename getMemoryBehavior.

    getMemoryBehavior is also used by SILInstruction. This commit renames
    getMemoryBehavior to computeMemoryBehavior and cleans some of the code
    that touches it.

// I forgot to add this file in my previous commit.

Author: nadavrot

Diff for: include/swift/SILAnalysis/AliasAnalysis.h

@@ -110,51 +110,48 @@ class AliasAnalysis : public SILAnalysis {
   ///
   /// TODO: When ref count behavior is separated from generic memory behavior,
   /// the IgnoreRefCountIncrements flag will be unnecessary.
-  MemoryBehavior getMemoryBehavior(SILInstruction *Inst, SILValue V,
-                                   RetainObserveKind);
+  MemoryBehavior computeMemoryBehavior(SILInstruction *Inst, SILValue V,
+                                       RetainObserveKind);
 
   /// Returns true if \p Inst may read from memory in a manner that
   /// affects V.
   bool mayReadFromMemory(SILInstruction *Inst, SILValue V) {
-    MemoryBehavior B = getMemoryBehavior(Inst, V,
-                                         RetainObserveKind::IgnoreRetains);
+    auto B = computeMemoryBehavior(Inst, V, RetainObserveKind::IgnoreRetains);
     return B == MemoryBehavior::MayRead ||
-      B == MemoryBehavior::MayReadWrite ||
-      B == MemoryBehavior::MayHaveSideEffects;
+           B == MemoryBehavior::MayReadWrite ||
+           B == MemoryBehavior::MayHaveSideEffects;
   }
 
   /// Returns true if \p Inst may write to memory in a manner that
   /// affects V.
   bool mayWriteToMemory(SILInstruction *Inst, SILValue V) {
-    MemoryBehavior B = getMemoryBehavior(Inst, V,
-                                         RetainObserveKind::IgnoreRetains);
+    auto B = computeMemoryBehavior(Inst, V, RetainObserveKind::IgnoreRetains);
     return B == MemoryBehavior::MayWrite ||
-      B == MemoryBehavior::MayReadWrite ||
-      B == MemoryBehavior::MayHaveSideEffects;
+           B == MemoryBehavior::MayReadWrite ||
+           B == MemoryBehavior::MayHaveSideEffects;
   }
 
   /// Returns true if \p Inst may read or write to memory in a manner that
   /// affects V.
   bool mayReadOrWriteMemory(SILInstruction *Inst, SILValue V) {
-    auto B = getMemoryBehavior(Inst, V, RetainObserveKind::IgnoreRetains);
-    return B != MemoryBehavior::None;
+    auto B = computeMemoryBehavior(Inst, V, RetainObserveKind::IgnoreRetains);
+    return MemoryBehavior::None != B;
   }
 
   /// Returns true if Inst may have side effects in a manner that affects V.
   bool mayHaveSideEffects(SILInstruction *Inst, SILValue V) {
-    MemoryBehavior B = getMemoryBehavior(Inst, V,
-                                         RetainObserveKind::ObserveRetains);
+    auto B = computeMemoryBehavior(Inst, V, RetainObserveKind::ObserveRetains);
     return B == MemoryBehavior::MayWrite ||
-      B == MemoryBehavior::MayReadWrite ||
-      B == MemoryBehavior::MayHaveSideEffects;
+           B == MemoryBehavior::MayReadWrite ||
+           B == MemoryBehavior::MayHaveSideEffects;
   }
 
   /// Returns true if Inst may have side effects in a manner that affects
   /// V. This is independent of whether or not Inst may write to V and is meant
   /// to encode notions such as ref count modifications.
   bool mayHavePureSideEffects(SILInstruction *Inst, SILValue V) {
-    return getMemoryBehavior(Inst, V, RetainObserveKind::ObserveRetains) ==
-           MemoryBehavior::MayHaveSideEffects;
+    auto B = computeMemoryBehavior(Inst, V, RetainObserveKind::ObserveRetains);
+    return MemoryBehavior::MayHaveSideEffects == B;
   }
 
   virtual void invalidate(SILAnalysis::InvalidationKind K) { AliasCache.clear(); }