Run windows tests directly in same shell

Occasionally the Windows tests will hang after all tests have completed
until the GitHub action times out. Using `Start-Process` with the
`-Wait` flag will wait for the process and all of its child processes to
terminate. This means that if the VS Code instance under test has any
lingering processes the build may hang forever.

Instead run the test command directly, referencing the success status
with `$LASTEXITCODE`. This should hopefully report the status more
reliably without hanging.

Author: plemarquand

Diff for: scripts/test_windows.ps1

@@ -64,10 +64,10 @@ npm ci -ignore-script node-pty
 npm run lint
 npm run format
 npm run package
-$Process = Start-Process npm "run integration-test" -Wait -PassThru -NoNewWindow
-if ($Process.ExitCode -eq 0) {
+npm run integration-test
+if ($LASTEXITCODE -eq 0) {
     Write-Host 'SUCCESS'
 } else {
-    Write-Host  ('FAILED ({0})' -f $Process.ExitCode)
+    Write-Host ('FAILED ({0})' -f $LASTEXITCODE)
     exit 1
 }

Diff for: test/integration-tests/utilities/testutilities.ts

@@ -23,6 +23,7 @@ import { waitForNoRunningTasks } from "../../utilities/tasks";
 import { closeAllEditors } from "../../utilities/commands";
 import { isDeepStrictEqual } from "util";
 import { Version } from "../../../src/utilities/version";
+import { SwiftOutputChannel } from "../../../src/ui/SwiftOutputChannel";
 import configuration from "../../../src/configuration";
 
 function getRootWorkspaceFolder(): vscode.WorkspaceFolder {
@@ -31,6 +32,12 @@ function getRootWorkspaceFolder(): vscode.WorkspaceFolder {
     return result;
 }
 
+function printLogs(outputChannel: SwiftOutputChannel, message: string) {
+    console.error(`${message}, captured logs are:`);
+    outputChannel.logs.map(log => console.log(log));
+    console.log("======== END OF LOGS ========\n\n");
+}
+
 const extensionBootstrapper = (() => {
     let activator: (() => Promise<Api>) | undefined = undefined;
     let activatedAPI: Api | undefined = undefined;
@@ -116,11 +123,10 @@ const extensionBootstrapper = (() => {
 
         mocha.afterEach(function () {
             if (this.currentTest && activatedAPI && this.currentTest.isFailed()) {
-                console.log(`Captured logs during ${testTitle(this.currentTest)}:`);
-                for (const log of activatedAPI.outputChannel.logs) {
-                    console.log(log);
-                }
-                console.log("======== END OF LOGS ========\n\n");
+                printLogs(
+                    activatedAPI.outputChannel,
+                    `Test failed: ${testTitle(this.currentTest)}`
+                );
             }
         });
 
@@ -136,9 +142,7 @@ const extensionBootstrapper = (() => {
                 }
             } catch (error) {
                 if (workspaceContext) {
-                    console.error(`Error during test/suite teardown, captured logs are:`);
-                    workspaceContext.outputChannel.logs.map(log => console.log(log));
-                    console.log("======== END OF LOGS ========\n\n");
+                    printLogs(workspaceContext.outputChannel, "Error during test/suite teardown");
                 }
                 // We always want to restore settings and deactivate the extension even if the
                 // user supplied teardown fails. That way we have the best chance at not causing
@@ -197,6 +201,10 @@ const extensionBootstrapper = (() => {
             }
 
             if (!workspaceContext) {
+                printLogs(
+                    activatedAPI.outputChannel,
+                    "Error during test/suite setup, workspace context could not be created"
+                );
                 throw new Error("Extension did not activate. Workspace context is not available.");
             }