Skip to content

Commit 43b5b5f

Browse files
author
Gwen Mittertreiner
committed
SR-15237 Fix typelayout_based_value_witness.swift
typelayout_based_value_witness.swift failed on iphoneos-arm64e due to an extra line of IR that gets generated. That meant the swift_release line had '#7' instead of '#6'. The test shouldn't be checking for '#6' anyways, so removed that check which causes the test to now pass.
1 parent 12a2e20 commit 43b5b5f

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

Diff for: test/IRGen/typelayout_based_value_witness.swift

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// RUN: %target-swift-frontend -enable-type-layout -force-struct-type-layouts -primary-file %s -O -emit-ir | %FileCheck %s --check-prefix=FORCE-OPT --check-prefix=FORCE-OPT-%target-ptrsize
44
// RUN: %target-swift-frontend -primary-file %s -emit-ir | %FileCheck %s --check-prefix=NOTL
55

6-
// https://bugs.swift.org/browse/SR-15237
7-
// UNSUPPORTED: CPU=arm64e
8-
96
public struct B<T> {
107
var x: T
118
var y: T
@@ -130,7 +127,7 @@ public enum ForwardEnum<T> {
130127
// FORCE-OPT: [[CASTED:%.*]] = bitcast i8* [[OFFSET]] to %T30typelayout_based_value_witness1CC**
131128
// FORCE-OPT: %toDestroy = load %T30typelayout_based_value_witness1CC*, %T30typelayout_based_value_witness1CC** [[CASTED]]
132129
// FORCE-OPT: [[FIELD:%.*]] = getelementptr %T30typelayout_based_value_witness1CC, %T30typelayout_based_value_witness1CC* %toDestroy, {{(i64|i32)}} 0, i32 0
133-
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]]) #6
130+
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]])
134131
// FORCE-OPT: ret void
135132
// FORCE-OPT:}
136133

@@ -151,7 +148,7 @@ public enum ForwardEnum<T> {
151148
// FORCE-OPT: [[CASTED:%.*]] = bitcast i8* [[OFFSET]] to %T30typelayout_based_value_witness1CC**
152149
// FORCE-OPT: %toDestroy = load %T30typelayout_based_value_witness1CC*, %T30typelayout_based_value_witness1CC** [[CASTED]]
153150
// FORCE-OPT: [[FIELD:%.*]] = getelementptr %T30typelayout_based_value_witness1CC, %T30typelayout_based_value_witness1CC* %toDestroy, {{(i64|i32)}} 0, i32 0
154-
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]]) #6
151+
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]])
155152
// FORCE-OPT: ret void
156153
// FORCE-OPT:}
157154

0 commit comments

Comments
 (0)