Skip to content

Commit 434300e

Browse files
committed
Optimize code && fix tests
1 parent 84c7062 commit 434300e

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

src/network/socket.cc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,12 @@ int Socket::sendfile_blocking(const char *filename, off_t offset, size_t length,
108108
sent_bytes = (length - offset > SW_SENDFILE_CHUNK_SIZE) ? SW_SENDFILE_CHUNK_SIZE : length - offset;
109109
n = sendfile(file, &offset, sent_bytes);
110110
if (n <= 0) {
111-
if (errno == EAGAIN && wait_event(timeout_ms, ssl_want_read ? SW_EVENT_READ : SW_EVENT_WRITE) < 0) {
111+
#ifdef SW_USE_OPENSSL
112+
int event = ssl_want_read ? SW_EVENT_READ : SW_EVENT_WRITE;
113+
#else
114+
int event = SW_EVENT_WRITE;
115+
#endif
116+
if (errno == EAGAIN && wait_event(timeout_ms, event) < 0) {
112117
return SW_ERR;
113118
}
114119
swoole_sys_warning("sendfile(%d, %s) failed", fd, filename);

src/wrapper/event.cc

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222

2323
#include <mutex>
2424

25-
using namespace swoole;
26-
25+
using swoole::Callback;
26+
using swoole::Reactor;
27+
using swoole::ReactorHandler;
2728
using swoole::network::Socket;
2829

2930
static std::mutex init_lock;
@@ -49,9 +50,9 @@ int swoole_event_init(int flags) {
4950
reactor->wait_exit = 1;
5051
}
5152

52-
coroutine::Socket::init_reactor(reactor);
53-
coroutine::System::init_reactor(reactor);
54-
network::Client::init_reactor(reactor);
53+
swoole::coroutine::Socket::init_reactor(reactor);
54+
swoole::coroutine::System::init_reactor(reactor);
55+
swoole::network::Client::init_reactor(reactor);
5556

5657
SwooleTG.reactor = reactor;
5758

@@ -62,7 +63,7 @@ int swoole_event_add(Socket *socket, int events) {
6263
return SwooleTG.reactor->add(socket, events);
6364
}
6465

65-
int swoole_event_add_or_update(swoole::network::Socket *_socket, int event) {
66+
int swoole_event_add_or_update(Socket *_socket, int event) {
6667
if (event == SW_EVENT_READ) {
6768
return SwooleTG.reactor->add_read_event(_socket);
6869
} else if (event == SW_EVENT_WRITE) {
@@ -108,7 +109,7 @@ ssize_t swoole_event_write(Socket *socket, const void *data, size_t len) {
108109
return SwooleTG.reactor->write(SwooleTG.reactor, socket, data, len);
109110
}
110111

111-
ssize_t swoole_event_writev(swoole::network::Socket *socket, const iovec *iov, size_t iovcnt) {
112+
ssize_t swoole_event_writev(Socket *socket, const iovec *iov, size_t iovcnt) {
112113
return SwooleTG.reactor->writev(SwooleTG.reactor, socket, iov, iovcnt);
113114
}
114115

src/wrapper/timer.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
#include "swoole_api.h"
1818
#include "swoole_timer.h"
1919

20-
using namespace swoole;
20+
using swoole::Timer;
21+
using swoole::TimerCallback;
22+
using swoole::TimerNode;
2123

2224
#ifdef __MACH__
2325
Timer *sw_timer() {

0 commit comments

Comments
 (0)