Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/css-selector
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.5
Choose a base ref
...
head repository: symfony/css-selector
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.6
Choose a head ref
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 15, 2020

  1. Add missing dots at the end of exception messages

    @fabpot
    fabpot committed Mar 15, 2020
    Copy the full SHA
    95f483b View commit details

  2. Merge branch '3.4' into 4.4 

    * 3.4:
  Add missing dots at the end of exception messages
    @fabpot
    fabpot committed Mar 15, 2020
    Copy the full SHA
    8f6f95b View commit details

Commits on Mar 16, 2020

  1. Fix quotes in exception messages

    @fabpot
    fabpot committed Mar 16, 2020
    Copy the full SHA
    9ccf6e7 View commit details

  2. Merge branch '3.4' into 4.4 

    * 3.4:
  Fix quotes in exception messages
    @fabpot
    fabpot committed Mar 16, 2020
    Copy the full SHA
    402251c View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 Parser/Handler/StringHandler.php
  2. +1 −1 XPath/Extension/FunctionExtension.php
2 changes: 1 addition & 1 deletion Parser/Handler/StringHandler.php
View file
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ public function handle(Reader $reader, TokenStream $stream): bool
$match = $reader->findPattern($this->patterns->getQuotedStringPattern($quote));

if (!$match) {
throw new InternalErrorException(sprintf('Should have found at least an empty match at %s.', $reader->getPosition()));
throw new InternalErrorException(sprintf('Should have found at least an empty match at %d.', $reader->getPosition()));
}

// check unclosed strings
2 changes: 1 addition & 1 deletion XPath/Extension/FunctionExtension.php
View file
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ public function translateNthChild(XPathExpr $xpath, FunctionNode $function, bool
try {
list($a, $b) = Parser::parseSeries($function->getArguments());
} catch (SyntaxErrorException $e) {
throw new ExpressionErrorException(sprintf('Invalid series: %s', implode(', ', $function->getArguments())), 0, $e);
throw new ExpressionErrorException(sprintf('Invalid series: "%s".', implode('", "', $function->getArguments())), 0, $e);
}

$xpath->addStarPrefix();