Skip to content

Commit 3dfa5a1

Browse files
committed
minor #837 Enabled the no_superfluous_phpdoc_tags fixer rule (javiereguiluz)
This PR was merged into the master branch. Discussion ---------- Enabled the no_superfluous_phpdoc_tags fixer rule Our code was already good 😎 ... but this rule removed some unneeded PHPdoc. Commits ------- f8483c2 Enabled the no_superfluous_phpdoc_tags fixer rule
2 parents d9b74a1 + f8483c2 commit 3dfa5a1

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

.php_cs.dist

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ return PhpCsFixer\Config::create()
3030
'linebreak_after_opening_tag' => true,
3131
'mb_str_functions' => true,
3232
'no_php4_constructor' => true,
33+
'no_superfluous_phpdoc_tags' => true,
3334
'no_unreachable_default_argument_value' => true,
3435
'no_useless_else' => true,
3536
'no_useless_return' => true,

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"require-dev": {
3333
"dama/doctrine-test-bundle": "^5.0",
3434
"doctrine/doctrine-fixtures-bundle": "^3.0",
35-
"friendsofphp/php-cs-fixer": "^2.7",
35+
"friendsofphp/php-cs-fixer": "^2.12",
3636
"symfony/browser-kit": "^4.1",
3737
"symfony/css-selector": "^4.1",
3838
"symfony/debug-bundle": "^4.1",

composer.lock

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Form/DataTransformer/TagArrayToStringTransformerTest.php

-4
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ public function testTransform()
102102
* simplify the tests. See https://phpunit.de/manual/current/en/test-doubles.html.
103103
*
104104
* @param array $findByReturnValues The values returned when calling to the findBy() method
105-
*
106-
* @return TagArrayToStringTransformer
107105
*/
108106
private function getMockedTransformer(array $findByReturnValues = []): TagArrayToStringTransformer
109107
{
@@ -121,8 +119,6 @@ private function getMockedTransformer(array $findByReturnValues = []): TagArrayT
121119
* This helper method creates a Tag instance for the given tag name.
122120
*
123121
* @param string $name
124-
*
125-
* @return Tag
126122
*/
127123
private function createTag($name): Tag
128124
{

0 commit comments

Comments
 (0)