minor #823 Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 polyfill (javiereguiluz)

javiereguiluz · javiereguiluz · commit 999898714703 · 2018-06-28T16:32:45.000+02:00
This PR was merged into the master branch. Discussion ---------- Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 polyfill Commits ------- d2f6d14 Use PHP_OS_FAMILY constant thanks to Symfony's PHP 7.2 polyfill
diff --git a/composer.json b/composer.json
@@ -19,6 +19,7 @@
         "symfony/form": "^4.1",
         "symfony/framework-bundle": "^4.1",
         "symfony/monolog-bundle": "^3.1",
+        "symfony/polyfill-php72": "^1.8",
         "symfony/security-bundle": "^4.1",
         "symfony/swiftmailer-bundle": "^3.1",
         "symfony/translation": "^4.1",
diff --git a/composer.lock b/composer.lock
diff --git a/tests/Command/AddUserCommandTest.php b/tests/Command/AddUserCommandTest.php
@@ -33,9 +33,7 @@ protected function setUp()
         exec('stty 2>&1', $output, $exitcode);
         $isSttySupported = 0 === $exitcode;
 
-        $isWindows = '\\' === \DIRECTORY_SEPARATOR;
-
-        if ($isWindows || !$isSttySupported) {
+        if ('Windows' === PHP_OS_FAMILY || !$isSttySupported) {
             $this->markTestSkipped('`stty` is required to test this command.');
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,7 @@ protected function setUp()`
`33`	`33`	`exec('stty 2>&1', $output, $exitcode);`
`34`	`34`	`$isSttySupported = 0 === $exitcode;`
`35`	`35`
`36`		`- $isWindows = '\\' === \DIRECTORY_SEPARATOR;`
`37`		`-`
`38`		`- if ($isWindows \|\| !$isSttySupported) {`
	`36`	`+ if ('Windows' === PHP_OS_FAMILY \|\| !$isSttySupported) {`
`39`	`37`	$this->markTestSkipped('`stty` is required to test this command.');
`40`	`38`	`}`
`41`	`39`	`}`