Skip to content

Commit 9b4e412

Browse files
committed
feature #1330 Display source code using dark mode (javiereguiluz)
This PR was merged into the main branch. Discussion ---------- Display source code using dark mode Creating a "dark mode" style for this application is outside of the scope of the project, so we're not going to do it. However, I propose to use a "dark mode" style to display the source code in the modal windows. In addition to being the most common style for developers, showing it in "dark mode" further emphasizes the difference between the application interface and its code: **Before / After** ![code-highlight-comparison](https://user-images.githubusercontent.com/73419/166917649-3d4d30a3-6f31-4cdc-a834-bfb82528a72f.jpg) Commits ------- 0e1ff29 Display source code using dark mode
2 parents e7cc207 + 0e1ff29 commit 9b4e412

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

assets/styles/app.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ $lato-font-path: '~lato-font/fonts';
1212
@import "~bootswatch/flatly/bootswatch";
1313
@import "~@fortawesome/fontawesome-free/css/all.css";
1414
@import "~@fortawesome/fontawesome-free/css/v4-shims.css";
15-
@import "~highlight.js/styles/base16/solarized-light.css";
15+
@import "~highlight.js/styles/github-dark-dimmed.css";
1616

1717
// pick the Lato fonts individually to avoid importing the entire font family
1818
@import '~lato-font/scss/public-api';

public/build/979.4967399b.js renamed to public/build/347.099e0365.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/979.dc75718b.css renamed to public/build/347.484d2f6c.css

+8-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/app.a5511055.js renamed to public/build/app.f1db5e65.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/entrypoints.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
"/build/runtime.96aa4ea2.js",
66
"/build/755.f5cf308f.js",
77
"/build/498.3bafb5f9.js",
8-
"/build/979.4967399b.js",
9-
"/build/app.a5511055.js"
8+
"/build/347.099e0365.js",
9+
"/build/app.f1db5e65.js"
1010
],
1111
"css": [
12-
"/build/979.dc75718b.css",
12+
"/build/347.484d2f6c.css",
1313
"/build/app.f66338b0.css"
1414
]
1515
},
@@ -46,9 +46,9 @@
4646
"/build/runtime.96aa4ea2.js": "sha384-nMYLpi/v3txwhZt8UOBsMOTbgVmUPlpD8cPmrU3yblZ7Yg8l799XS9NC1BZ9P9Xs",
4747
"/build/755.f5cf308f.js": "sha384-SAv+SyvZr31CmFrJFfKEYK0fDrMVx8vh19SI4QznAB/ar+Z1k6IT9Mg2SDZtLwD2",
4848
"/build/498.3bafb5f9.js": "sha384-yoQvBlSFO4jMdQIBvie1V5XQ4M8F0CGnS2mFtS9RslTqLbW8IYO/xONlip3SUDGH",
49-
"/build/979.4967399b.js": "sha384-IPkjWWHEhfdos/b3w08uBZ2KjTFno/Ocwt1o6ardQjWJEbigWocfHbAeZfj+t7AX",
50-
"/build/app.a5511055.js": "sha384-t5u9zzpbS+SwUVCOSeCZdoFdZ5n1rIZ5nWHPzaEYkZ6U2oaG2AOokBmGXzL7uORK",
51-
"/build/979.dc75718b.css": "sha384-3Xq9zpkhbAPpNpmbJIfOIsDjVugU/PSQ4vcam/DSyD65+CvSOnCrlxkY+RpzfNKN",
49+
"/build/347.099e0365.js": "sha384-OyxwFmS/gA7lb0u0BQeQneUmxS+yTASnmvhmTgNdO3J02ghh4ZO8/qFdtMl/AhLr",
50+
"/build/app.f1db5e65.js": "sha384-FRTtq8dHuogsqAkbmJ1Jq759Fo/3RWXiUUWpdkAF0j+ZD/MRx1mWfJjXBd86qs2R",
51+
"/build/347.484d2f6c.css": "sha384-ZOokpnTV8wl6Db+viUkheay5Zi+h5AxTIUfrHzDQQQGBbpxSydOT+j8E619FtN6U",
5252
"/build/app.f66338b0.css": "sha384-KA475JLog/ODk4eDLal8AC7va3Rpmyw4GCOfZJrhCxpm2B2itR0J3w1NAKF38hJ9",
5353
"/build/login.395771d5.js": "sha384-bKBy5bAsLAFHFo/zxqJkheRiwvRSVHXwogJPw7DWc6qfnP03VaNFMyEc/0cRBf0k",
5454
"/build/919.63ff4a5d.js": "sha384-0o9glCmkeYT/iE8RHdbPnoqMslSFjP/uN4ggsyjBVE5eq+V2RUFdEzYZBs5JNiyb",

public/build/manifest.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"build/app.css": "/build/app.f66338b0.css",
3-
"build/app.js": "/build/app.a5511055.js",
3+
"build/app.js": "/build/app.f1db5e65.js",
44
"build/login.js": "/build/login.395771d5.js",
55
"build/admin.css": "/build/admin.691f9b8c.css",
66
"build/admin.js": "/build/admin.587634ca.js",
@@ -9,8 +9,8 @@
99
"build/755.f5cf308f.js": "/build/755.f5cf308f.js",
1010
"build/498.3bafb5f9.js": "/build/498.3bafb5f9.js",
1111
"build/919.63ff4a5d.js": "/build/919.63ff4a5d.js",
12-
"build/979.dc75718b.css": "/build/979.dc75718b.css",
13-
"build/979.4967399b.js": "/build/979.4967399b.js",
12+
"build/347.484d2f6c.css": "/build/347.484d2f6c.css",
13+
"build/347.099e0365.js": "/build/347.099e0365.js",
1414
"build/95.ce62c8da.js": "/build/95.ce62c8da.js",
1515
"build/images/fa-solid-900.svg": "/build/images/fa-solid-900.13de59f1.svg",
1616
"build/images/fa-brands-400.svg": "/build/images/fa-brands-400.216edb96.svg",

0 commit comments

Comments
 (0)