minor #1515 Mark some properties and classes as readonly (javiereguiluz)

This PR was merged into the main branch.

Discussion
----------

Mark some properties and classes as readonly

Commits
-------

06f3d60 Mark some properties and classes as readonly

Author: javiereguiluz

src/EventSubscriber/CheckRequirementsSubscriber.php

@@ -29,10 +29,10 @@
  *
  * @author Javier Eguiluz <[email protected]>
  */
-final class CheckRequirementsSubscriber implements EventSubscriberInterface
+final readonly class CheckRequirementsSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private readonly EntityManagerInterface $entityManager
+        private EntityManagerInterface $entityManager
     ) {
     }
 

src/EventSubscriber/CommentNotificationSubscriber.php

@@ -26,14 +26,14 @@
  *
  * @author Oleg Voronkovich <[email protected]>
  */
-final class CommentNotificationSubscriber implements EventSubscriberInterface
+final readonly class CommentNotificationSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private readonly MailerInterface $mailer,
-        private readonly UrlGeneratorInterface $urlGenerator,
-        private readonly TranslatorInterface $translator,
+        private MailerInterface $mailer,
+        private UrlGeneratorInterface $urlGenerator,
+        private TranslatorInterface $translator,
         #[Autowire('%app.notifications.email_sender%')]
-        private readonly string $sender
+        private string $sender
     ) {
     }
 

src/EventSubscriber/ControllerSubscriber.php

@@ -23,10 +23,10 @@
  * @author Ryan Weaver <[email protected]>
  * @author Javier Eguiluz <[email protected]>
  */
-final class ControllerSubscriber implements EventSubscriberInterface
+final readonly class ControllerSubscriber implements EventSubscriberInterface
 {
     public function __construct(
-        private readonly SourceCodeExtension $twigExtension
+        private SourceCodeExtension $twigExtension
     ) {
     }
 

src/Form/DataTransformer/TagArrayToStringTransformer.php

@@ -27,10 +27,10 @@
  *
  * @template-implements DataTransformerInterface<Tag[], string>
  */
-final class TagArrayToStringTransformer implements DataTransformerInterface
+final readonly class TagArrayToStringTransformer implements DataTransformerInterface
 {
     public function __construct(
-        private readonly TagRepository $tags
+        private TagRepository $tags
     ) {
     }
 

src/Twig/AppExtension.php

@@ -33,7 +33,7 @@ final class AppExtension extends AbstractExtension
     // See https://symfony.com/doc/current/service_container.html#binding-arguments-by-name-or-type
     public function __construct(
         /** @var string[] */
-        private array $enabledLocales,
+        private readonly array $enabledLocales,
     ) {
     }
 

src/Twig/SourceCodeExtension.php

@@ -36,7 +36,7 @@ final class SourceCodeExtension extends AbstractExtension
     private $controller;
 
     public function __construct(
-        private FileLinkFormatter $fileLinkFormat,
+        private readonly FileLinkFormatter $fileLinkFormat,
         #[Autowire('%kernel.project_dir%')]
         private string $projectDir,
     ) {