Skip to content

Commit c8ba26c

Browse files
committed
feature #855 Updating composer deps, don't fail tests on vendor deprecations (bobdenotter)
This PR was squashed before being merged into the master branch (closes #855). Discussion ---------- Updating composer deps, don't fail tests on vendor deprecations Follows #846, replaces #854 I've taken the liberty of updating @nicolas-grekas' PR to update flex to 1.1, whilst keeping bound constraints for the symfony components. Tests would fail on a deprecation in doctrine/common. I have also added a temporary `SYMFONY_DEPRECATIONS_HELPER=weak_vendors`, so it'll pass tests. After Symfony 4.2 has been released, I'll remove it. Commits ------- bbe1e49 Updating composer deps, don't fail tests on vendor deprecations
2 parents 8cda513 + bbe1e49 commit c8ba26c

10 files changed

+518
-259
lines changed

bin/phpunit

+4
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,9 @@ if (false === getenv('SYMFONY_PHPUNIT_VERSION')) {
1414
if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
1515
putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
1616
}
17+
if (false === getenv('SYMFONY_DEPRECATIONS_HELPER')) {
18+
// see https://symfony.com/doc/current/components/phpunit_bridge.html#making-tests-fail
19+
putenv('SYMFONY_DEPRECATIONS_HELPER=999999');
20+
}
1721

1822
require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit';

composer.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"sensiolabs/security-checker": "^4.1",
1616
"symfony/asset": "^4.1",
1717
"symfony/expression-language": "^4.1",
18-
"symfony/flex": "^1.0.86",
18+
"symfony/flex": "^1.1",
1919
"symfony/form": "^4.1",
2020
"symfony/framework-bundle": "^4.1",
2121
"symfony/monolog-bundle": "^3.1",
@@ -79,7 +79,8 @@
7979
},
8080
"extra": {
8181
"symfony": {
82-
"allow-contrib": true
82+
"allow-contrib": true,
83+
"require": "4.1.*"
8384
}
8485
}
8586
}

0 commit comments

Comments
 (0)