Skip to content

Upgrade yarn packages to latest #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tacman opened this issue Jul 2, 2022 · 4 comments · Fixed by #1343
Closed

Upgrade yarn packages to latest #1342

tacman opened this issue Jul 2, 2022 · 4 comments · Fixed by #1343

Comments

@tacman
Copy link
Contributor

tacman commented Jul 2, 2022

Since this is the demo program that shows best practices, is there any reason not to update to the latest packages? In particular, Webpack and stimulus.

@symfony/stimulus-bridge      2.1.0   -> 3.2.1                                                     
@symfony/webpack-encore       1.4.0 ->  2.1.0                                 
stimulus                      2.0.0  ->  3.0.1  

I'm happy to do a PR, but wanted to see if there was any particular reason to keep these older versions in the branch that works with 6.1.

@javiereguiluz
Copy link
Member

There's no reason to keep the old versions, so please submit a PR to update this. Thanks!

@94noni
Copy link
Contributor

94noni commented Jul 7, 2022

Works already done on my PR proposing to add stimulus
#1284
it was an early comment :)

@javiereguiluz
Copy link
Member

@94noni sorry for not having taken care of your PR earlier. I've decided to merge this PR because your PR already needs some rebasing, so the new conflicts won't complicate things much.

I'll try to take care of your PR soon. Thanks.

@94noni
Copy link
Contributor

94noni commented Jul 8, 2022

@javiereguiluz great news, yes and as explain I got some conflict/problem trying to recompile new assets before versioning them :s
anyways, nice that this project is up to date now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants