Skip to content

[Bug] Asset symlinks are not removed when removing packages #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Apr 3, 2017 · 6 comments
Closed
Labels

Comments

@javiereguiluz
Copy link
Member

How to reproduce:

  1. $ composer req admin
  2. web/bundles/easyadmin symlink is created pointing at ../vendor/[...]/public/
  3. $ composer rem admin
  4. web/bundles/easyadmin symlink still exists
@fabpot
Copy link
Member

fabpot commented Apr 5, 2017

That's probably because when you uninstalled easyadmin, it also uninstalled symfony/cli (as it was installed via easyadmin), so the assets:install task couldn't run. Not sure what we can do.

@fabpot
Copy link
Member

fabpot commented Jun 14, 2017

Closing as there is nothing we can do to fix this one.

@fabpot fabpot closed this as completed Jun 14, 2017
@stof
Copy link
Member

stof commented Jun 14, 2017

@fabpot assets:install does not delete existing symlinks/folders if the corresponding bundle does not provide assets anymore. It does not clean the existing content of the file for unnecessary bundle folders.

@stof
Copy link
Member

stof commented Jun 14, 2017

see symfony/demo#588 where I had to do a cleanup manually (it required doing a rm -rf web/bundles before running assets:install to have the clean state)

@fabpot
Copy link
Member

fabpot commented Jun 14, 2017

So, that's a bug that needs to be reported on symfony/symfony. That's not related to Flex.

@stof
Copy link
Member

stof commented Jun 14, 2017

@fabpot I created the issue on the symfony repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants