Skip to content

Commit afc96da

Browse files
committed
bug #35486 [Translator] Default value for 'sort' option in translation:update should be 'asc' (versgui)
This PR was squashed before being merged into the 4.4 branch (closes #35486). Discussion ---------- [Translator] Default value for 'sort' option in translation:update should be 'asc' | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | The value for 'sort' option for `bin/console translation:update --sort` is optional, but no default value is defined. So the list isn't sorted if no value is explicitly defined. This MR brings a default value "asc" if no value is defined, so the list is correctly sorted. Commits ------- fdb13c8ab8 [Translator] Default value for 'sort' option in translation:update should be 'asc'
2 parents 7c2cc5b + e31a0b5 commit afc96da

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

Command/TranslationUpdateCommand.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ protected function configure()
8383
new InputOption('clean', null, InputOption::VALUE_NONE, 'Should clean not found messages'),
8484
new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'Specify the domain to update'),
8585
new InputOption('xliff-version', null, InputOption::VALUE_OPTIONAL, 'Override the default xliff version', '1.2'),
86-
new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically'),
86+
new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically', 'asc'),
8787
])
8888
->setDescription('Updates the translation file')
8989
->setHelp(<<<'EOF'

Tests/Command/TranslationUpdateCommandTest.php

+8
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ public function testDumpReverseSortedMessagesAndClean()
4848
$this->assertRegExp('/3 messages were successfully extracted/', $tester->getDisplay());
4949
}
5050

51+
public function testDumpSortWithoutValueAndClean()
52+
{
53+
$tester = $this->createCommandTester(['messages' => ['foo' => 'foo', 'test' => 'test', 'bar' => 'bar']]);
54+
$tester->execute(['command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true, '--sort']);
55+
$this->assertRegExp("/\*bar\*foo\*test/", preg_replace('/\s+/', '', $tester->getDisplay()));
56+
$this->assertRegExp('/3 messages were successfully extracted/', $tester->getDisplay());
57+
}
58+
5159
public function testDumpWrongSortAndClean()
5260
{
5361
$tester = $this->createCommandTester(['messages' => ['foo' => 'foo', 'test' => 'test', 'bar' => 'bar']]);

0 commit comments

Comments
 (0)