Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit 72353a9

Browse files
Hugo Hamonfabpot
Hugo Hamon
authored andcommitted
[jobeet] fixed minor typos and trac tickets
1 parent 8efaef3 commit 72353a9

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

jobeet/en/05.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Day 5: The Routing
22
==================
33

44
If you've completed day 4, you should now be familiar with the MVC pattern
5-
andit should be feeling like a more and more natural way of coding. Spend a bit
5+
and it should be feeling like a more and more natural way of coding. Spend a bit
66
more time with it and you won't look back. To practice a bit, we customized the
77
Jobeet pages and in the process, also reviewed several symfony concepts, like
88
the layout, helpers, and slots.

jobeet/en/08.markdown

+7-7
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ Unit Tests
3333
----------
3434

3535
Writing unit tests is perhaps one of the hardest web development best practices
36-
to put into action. As web developers are not really used to test their work, a
37-
lot of questions arise: Do I have to write tests before implementing a feature?
38-
What do I need to test? Do my tests need to cover every single ~edge case|Edge
39-
Cases~? How can I be sure that everything is well tested? But usually, the first
40-
question is much more basic: Where to start?
36+
to put into action. As web developers are not really used to testing their work,
37+
a lot of questions arise: Do I have to write tests before implementing a
38+
feature? What do I need to test? Do my tests need to cover every single ~edge
39+
case|Edge Cases~? How can I be sure that everything is well tested? But usually,
40+
the first question is much more basic: Where to start?
4141

4242
Even if we strongly advocate testing, the symfony approach is pragmatic: it's
4343
always better to have some tests than no test at all. Do you already have a lot
@@ -47,7 +47,7 @@ you find a bug in your code. Over time, your code will become better, the ~code
4747
coverage|Code Coverage~ will rise, and you will become more confident about it.
4848
By starting with a pragmatic approach, you will feel more comfortable with tests
4949
over time. The next step is to write tests for new features. In no time, you
50-
will become test addict.
50+
will become a test addict.
5151

5252
The problem with most testing libraries is their steep learning curve. That's
5353
why symfony provides a very simple testing library, **lime**, to make writing
@@ -194,7 +194,7 @@ identify the behavior that fails.
194194

195195
All lime test methods take a string as their last argument that serves as the
196196
description for the test. It's very convenient as it forces you to describe what
197-
your are really testing. It can also serve as a form of
197+
you are really testing. It can also serve as a form of
198198
~documentation|Documentation~ for a method's expected behavior. Let's add some
199199
messages to the `slugify` test file:
200200

jobeet/en/10.markdown

+2-1
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ from a form is as simple as unsetting them:
178178
<doctrine>
179179
// lib/form/doctrine/JobeetJobForm.class.php
180180
</doctrine>
181+
181182
class JobeetJobForm extends BaseJobeetJobForm
182183
{
183184
public function configure()
@@ -398,7 +399,7 @@ We also need to change the default validator:
398399
>You need to create the logo directory (`web/uploads/jobs/`) and check that it
399400
>is writable by the web server.
400401
401-
As the validator will save the relative path in the database, change the path
402+
As the validator only saves the filename in the database, change the path
402403
used in the `showSuccess` template:
403404

404405
[php]

jobeet/en/17.markdown

+1
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,7 @@ of an error:
296296
We also need to override the `delete()` method to remove the entry of the
297297
deleted job from the index:
298298

299+
<propel>
299300
[php]
300301
// lib/model/JobeetJob.php
301302
public function delete(PropelPDO $con = null)

0 commit comments

Comments
 (0)