Skip to content

Add type definitions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TaylorBeeston opened this issue Jul 11, 2020 · 0 comments
Closed

Add type definitions #13

TaylorBeeston opened this issue Jul 11, 2020 · 0 comments
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Comments

@TaylorBeeston
Copy link
Contributor

Subject of the feature

Add TypeScript type definitions

Problem

It is currently difficult to use this package in a TypeScript project due to a lack of type definitions. This in turn also makes it different to add type definitions to a package that depends on this package (such as hast-util-sanitize).

Expected behaviour

When importing this module into a TypeScript project, the type should automatically be declared.

Alternatives

An alternative to simply adding a .d.ts file would be to actually convert the whole package to TypeScript, however it is much easier to simply add a .d.ts file.

@TaylorBeeston TaylorBeeston added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Jul 11, 2020
@wooorm wooorm closed this as completed in 4c68156 Jul 13, 2020
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 🦋 type/enhancement This is great to have 🧑 semver/major This is a change and removed 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Jul 13, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

No branches or pull requests

2 participants