no need to require parent_node_ext explicitly

Author: flyerhzm

.github/workflows/main.yml

@@ -22,8 +22,6 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
-    - name: Run tests for siblings
-      run: TEST_SIBLINGS=true bundle exec rake
 
   deploy:
     runs-on: ubuntu-latest

spec/node_query/adapter/parser_spec.rb

@@ -38,14 +38,10 @@
     end
   end
 
-  if ENV['TEST_SIBLINGS'] == 'true'
-    require 'parser_node_ext/parent_node_ext'
-
-    describe "#get_siblings" do
-      it "gets the siblings of node" do
-        node = parser_parse("class Synvert; end").children.first
-        expect(adapter.get_siblings(node)).to eq [nil, nil]
-      end
+  describe "#get_siblings" do
+    it "gets the siblings of node" do
+      node = parser_parse("class Synvert; end").children.first
+      expect(adapter.get_siblings(node)).to eq [nil, nil]
     end
   end
 end

spec/node_query/adapter/prism_spec.rb

@@ -43,18 +43,14 @@
     end
   end
 
-  if ENV['TEST_SIBLINGS'] == 'true'
-    require 'prism_ext/parent_node_ext'
-
-    describe "#get_siblings" do
-      it "gets the siblings of node" do
-        node = prism_parse("class Synvert; end").body.first.constant_path
-        siblings = adapter.get_siblings(node)
-        expect(siblings.size).to eq 5
-        expect(siblings[0]).to be_nil
-        expect(siblings[1]).to be_nil
-        expect(siblings[4]).to eq :Synvert
-      end
+  describe "#get_siblings" do
+    it "gets the siblings of node" do
+      node = prism_parse("class Synvert; end").body.first.constant_path
+      siblings = adapter.get_siblings(node)
+      expect(siblings.size).to eq 5
+      expect(siblings[0]).to be_nil
+      expect(siblings[1]).to be_nil
+      expect(siblings[4]).to eq :Synvert
     end
   end
 end

spec/node_query/adapter/syntax_tree_spec.rb

@@ -42,17 +42,13 @@
     end
   end
 
-  if ENV['TEST_SIBLINGS'] == 'true'
-    require 'syntax_tree_ext/parent_node_ext'
-
-    describe "#get_siblings" do
-      it "gets the siblings of node" do
-        node = syntax_tree_parse("class Synvert; end").body.first.constant
-        siblings = adapter.get_siblings(node)
-        expect(siblings.size).to eq 2
-        expect(siblings[0]).to be_nil
-        expect(siblings[1].class).to eq SyntaxTree::BodyStmt
-      end
+  describe "#get_siblings" do
+    it "gets the siblings of node" do
+      node = syntax_tree_parse("class Synvert; end").body.first.constant
+      siblings = adapter.get_siblings(node)
+      expect(siblings.size).to eq 2
+      expect(siblings[0]).to be_nil
+      expect(siblings[1].class).to eq SyntaxTree::BodyStmt
     end
   end
 end

spec/node_query_parser/parser_spec.rb

@@ -145,18 +145,14 @@ def initialize(id, name)
         expect(expression.query_nodes(node)).to eq [node.body.first.body.first.body.first]
       end
 
-      if ENV['TEST_SIBLINGS'] == 'true'
-        require 'parser_node_ext/parent_node_ext'
-
-        it 'matches next sibling node' do
-          expression = parser.parse('.ivasgn[variable=@id] + .ivasgn[variable=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.body.first.body[1]]
-        end
-
-        it 'matches sebsequent sibling node' do
-          expression = parser.parse('.ivasgn[variable=@id] ~ .ivasgn[variable=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.body.first.body[1]]
-        end
+      it 'matches next sibling node' do
+        expression = parser.parse('.ivasgn[variable=@id] + .ivasgn[variable=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.body.first.body[1]]
+      end
+
+      it 'matches sebsequent sibling node' do
+        expression = parser.parse('.ivasgn[variable=@id] ~ .ivasgn[variable=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.body.first.body[1]]
       end
 
       it 'matches goto scope' do

spec/node_query_parser/prism_spec.rb

@@ -148,18 +148,14 @@ def initialize(id, name)
         expect(expression.query_nodes(node)).to eq [node.body.first.body.body.first.body.body.first.value]
       end
 
-      if ENV['TEST_SIBLINGS'] == 'true'
-        require 'prism_ext/parent_node_ext'
-
-        it 'matches next sibling node' do
-          expression = parser.parse('.instance_variable_write_node[name=@id] + .instance_variable_write_node[name=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.body.body.first.body.body.last]
-        end
-
-        it 'matches sebsequent sibling node' do
-          expression = parser.parse('.instance_variable_write_node[name=@id] ~ .instance_variable_write_node[name=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.body.body.first.body.body.last]
-        end
+      it 'matches next sibling node' do
+        expression = parser.parse('.instance_variable_write_node[name=@id] + .instance_variable_write_node[name=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.body.body.first.body.body.last]
+      end
+
+      it 'matches sebsequent sibling node' do
+        expression = parser.parse('.instance_variable_write_node[name=@id] ~ .instance_variable_write_node[name=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.body.body.first.body.body.last]
       end
 
       it 'matches goto scope' do

spec/node_query_parser/syntax_tree_spec.rb

@@ -148,18 +148,14 @@ def initialize(id, name)
         expect(expression.query_nodes(node)).to eq [node.body.first.bodystmt.statements.body.first.bodystmt.statements.body.first.target]
       end
 
-      if ENV['TEST_SIBLINGS'] == 'true'
-        require 'syntax_tree_ext/parent_node_ext'
-
-        it 'matches next sibling node' do
-          expression = parser.parse('.Assign[target=@id] + .Assign[target=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.bodystmt.statements.body.first.bodystmt.statements.body.last]
-        end
-
-        it 'matches sebsequent sibling node' do
-          expression = parser.parse('.Assign[target=@id] ~ .Assign[target=@name]')
-          expect(expression.query_nodes(node)).to eq [node.body.first.bodystmt.statements.body.first.bodystmt.statements.body.last]
-        end
+      it 'matches next sibling node' do
+        expression = parser.parse('.Assign[target=@id] + .Assign[target=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.bodystmt.statements.body.first.bodystmt.statements.body.last]
+      end
+
+      it 'matches sebsequent sibling node' do
+        expression = parser.parse('.Assign[target=@id] ~ .Assign[target=@name]')
+        expect(expression.query_nodes(node)).to eq [node.body.first.bodystmt.statements.body.first.bodystmt.statements.body.last]
       end
 
       it 'matches goto scope' do