Skip to content

Commit 0ac6ff2

Browse files
committed
use evaluateContent instead of eval
1 parent 2720649 commit 0ac6ff2

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

src/command.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import dedent from "dedent-js";
66
import compareVersions from "compare-versions";
77
import snakecaseKeys from "snakecase-keys";
88
import fetch from "node-fetch";
9-
import * as Synvert from "@synvert-hq/synvert-core";
9+
import { Rewriter, rewriteSnippetToAsyncVersion, evaluateContent, version as synvertCoreVersion } from "@synvert-hq/synvert-core";
1010

1111
import { groupNameType, Snippet } from "./types";
1212

@@ -28,7 +28,7 @@ export async function syncSnippets(): Promise<void> {
2828
"https://registry.npmjs.org/@synvert-hq/synvert-core/latest",
2929
);
3030
const json = await response.json();
31-
if (compareVersions.compare(json.version, Synvert.version, ">")) {
31+
if (compareVersions.compare(json.version, synvertCoreVersion, ">")) {
3232
const { stdout } = await exec("npm root -g");
3333
await exec(
3434
`cd ${stdout.trim()}/synvert; npm install @synvert-hq/synvert-core@${json.version}`,
@@ -41,13 +41,13 @@ export async function readSnippets(): Promise<void> {
4141
await Promise.all(
4242
paths.map(async (path) => {
4343
const snippet = await fs.readFile(path, "utf-8");
44-
eval(Synvert.rewriteSnippetToAsyncVersion(snippet));
44+
evaluateContent(rewriteSnippetToAsyncVersion(snippet), "Rewriter");
4545
}),
4646
);
4747
}
4848

4949
export async function listSnippets(format: string): Promise<void> {
50-
const rewriters = Synvert.Rewriter.rewriters;
50+
const rewriters = Rewriter.rewriters;
5151
if (format === "json") {
5252
console.log(JSON.stringify(snakecaseKeys(await availableSnippets())));
5353
} else {
@@ -66,7 +66,7 @@ export async function listSnippets(format: string): Promise<void> {
6666
}
6767

6868
export async function availableSnippets(): Promise<Snippet[]> {
69-
const rewriters = Synvert.Rewriter.rewriters;
69+
const rewriters = Rewriter.rewriters;
7070
const groupNames: groupNameType[] = [];
7171
Object.keys(rewriters).map((group) => {
7272
Object.keys(rewriters[group]).map((name) => {
@@ -157,7 +157,7 @@ export async function generateSnippet(snippetName: string): Promise<void> {
157157
}
158158

159159
export async function runSnippet(
160-
rewriter: Synvert.Rewriter<any>,
160+
rewriter: Rewriter<any>,
161161
format: string,
162162
): Promise<void> {
163163
if (format === "json") {
@@ -178,7 +178,7 @@ export async function runSnippet(
178178
}
179179

180180
export async function testSnippet(
181-
rewriter: Synvert.Rewriter<any>,
181+
rewriter: Rewriter<any>,
182182
): Promise<void> {
183183
const result = await rewriter.test();
184184
console.log(JSON.stringify(snakecaseKeys(result)));

src/index.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Command, flags } from "@oclif/command";
2-
import * as Synvert from "@synvert-hq/synvert-core";
2+
import { Configuration, Rewriter, evalSnippet, rewriteSnippetToAsyncVersion, evaluateContent, version as synvertCoreVersion } from "@synvert-hq/synvert-core";
33

44
import {
55
syncSnippets,
@@ -36,33 +36,33 @@ class SynvertCommand extends Command {
3636
return await generateSnippet(flags.generate);
3737
}
3838
if (flags["show-run-process"]) {
39-
Synvert.Configuration.showRunProcess = true;
39+
Configuration.showRunProcess = true;
4040
}
4141
if (flags["root-path"]) {
42-
Synvert.Configuration.rootPath = flags["root-path"];
42+
Configuration.rootPath = flags["root-path"];
4343
}
4444
if (flags["only-paths"]) {
45-
Synvert.Configuration.onlyPaths = flags["only-paths"]
45+
Configuration.onlyPaths = flags["only-paths"]
4646
.split(",")
4747
.map((onlyPath: string) => onlyPath.trim());
4848
}
4949
if (flags["skip-paths"]) {
50-
Synvert.Configuration.skipPaths = flags["skip-paths"]
50+
Configuration.skipPaths = flags["skip-paths"]
5151
.split(",")
5252
.map((skipPath: string) => skipPath.trim());
5353
}
54-
Synvert.Configuration.respectGitignore = !flags["dont-respect-gitignore"];
55-
Synvert.Configuration.maxFileSize = flags["max-file-size"];
56-
Synvert.Configuration.singleQuote = flags["single-quote"];
57-
Synvert.Configuration.semi = !flags["no-semi"];
58-
Synvert.Configuration.tabWidth = flags["tab-width"];
59-
Synvert.Configuration.strict = !flags["loose"];
54+
Configuration.respectGitignore = !flags["dont-respect-gitignore"];
55+
Configuration.maxFileSize = flags["max-file-size"];
56+
Configuration.singleQuote = flags["single-quote"];
57+
Configuration.semi = !flags["no-semi"];
58+
Configuration.tabWidth = flags["tab-width"];
59+
Configuration.strict = !flags["loose"];
6060
if (flags.run) {
61-
const rewriter = await Synvert.evalSnippet(flags.run);
61+
const rewriter = await evalSnippet(flags.run);
6262
await runSnippet(rewriter, this.format);
6363
}
6464
if (flags.test) {
65-
const rewriter = await Synvert.evalSnippet(flags.test);
65+
const rewriter = await evalSnippet(flags.test);
6666
await testSnippet(rewriter);
6767
}
6868
if (flags.execute) {
@@ -79,11 +79,11 @@ class SynvertCommand extends Command {
7979
showVersion(): void {
8080
const pjson = require("../package.json");
8181
console.log(
82-
`${pjson.version} (with @synvert-hq/synvert-core ${Synvert.version})`,
82+
`${pjson.version} (with @synvert-hq/synvert-core ${synvertCoreVersion})`,
8383
);
8484
}
8585

86-
private async evalSnippetByInput(): Promise<Synvert.Rewriter<any>> {
86+
private async evalSnippetByInput(): Promise<Rewriter<any>> {
8787
const snippet: string = await new Promise((resolve) => {
8888
let input = "";
8989
process.stdin.on("data", (data) => {
@@ -93,7 +93,7 @@ class SynvertCommand extends Command {
9393
resolve(input.toString());
9494
});
9595
});
96-
return eval(Synvert.rewriteSnippetToAsyncVersion(snippet));
96+
return evaluateContent(rewriteSnippetToAsyncVersion(snippet), "Rewriter");
9797
}
9898
}
9999

0 commit comments

Comments
 (0)