use for of to iterate

Author: flyerhzm

lib/javascript/prefer-class-properties.js

@@ -84,17 +84,17 @@ new Synvert.Rewriter("javascript", "prefer-class-properties", function () {
           },
         );
 
-        functions.forEach((func) => {
+        for (const func of functions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(func.left.name)} = ${this.mutationAdapter.getSource(func.right, {
               fixIndent: true,
             })}`,
             tabSize,
           );
           insert(`\n\n${source.replace(/function ?/, "").replace(/\) {/, ") => {")}`, { at: "end" });
-        });
+        }
 
-        arrowFunctions.forEach((arrowFunction) => {
+        for (const arrowFunction of arrowFunctions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(arrowFunction.left.name)} = ${this.mutationAdapter.getSource(
               arrowFunction.right,
@@ -103,7 +103,7 @@ new Synvert.Rewriter("javascript", "prefer-class-properties", function () {
             tabSize,
           );
           insert(`\n\n${source}`, { at: "end" });
-        });
+        }
       });
 
       // handleChange() {}

lib/react/prefer-class-properties.js

@@ -99,17 +99,17 @@ new Synvert.Rewriter("react", "prefer-class-properties", () => {
           },
         );
 
-        functions.forEach((func) => {
+        for (const func of functions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(func.left.name)} = ${this.mutationAdapter.getSource(func.right, {
               fixIndent: true,
             })}`,
             tabSize,
           );
           insert(`\n\n${source.replace(/function ?/, "").replace(/\) {/, ") => {")}`, { at: "end" });
-        });
+        }
 
-        arrowFunctions.forEach((arrowFunction) => {
+        for (const arrowFunction of arrowFunctions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(arrowFunction.left.name)} = ${this.mutationAdapter.getSource(
               arrowFunction.right,
@@ -118,7 +118,7 @@ new Synvert.Rewriter("react", "prefer-class-properties", () => {
             tabSize,
           );
           insert(`\n\n${source}`, { at: "end" });
-        });
+        }
       });
 
       // handleChange() {}

lib/react/transform-class-components-to-functions.js

@@ -42,9 +42,9 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
       findNode(
         ".VariableDeclarationList[declarations.length=1][declarations.0.initializer=.PropertyAccessExpression[expression=this][name=props]]",
         () => {
-          this.currentNode.declarations[0].name.elements.forEach((element) =>
-            addThisProp(currentFilePath, this.mutationAdapter.getSource(element)),
-          );
+          for (const element of this.currentNode.declarations[0].name.elements) {
+            addThisProp(currentFilePath, this.mutationAdapter.getSource(element));
+          }
         },
       );
 
@@ -55,7 +55,7 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
 
       // state = { key: value };
       findNode(".PropertyDeclaration[name=state]", () => {
-        this.currentNode.initializer.properties.forEach((property) => {
+        for (const property of this.currentNode.initializer.properties) {
           const name = property.name.escapedText;
           const value = this.mutationAdapter.getSource(property.initializer);
           functionBody.push(
@@ -64,7 +64,7 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
               1,
             ),
           );
-        });
+        }
       });
 
       // foo = () => {}
@@ -84,15 +84,15 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
       if (lifecycleMethods.length > 0) {
         functionBody.push(addLeadingSpaces("// Synvert TODO: convert lifecycle methods to useEffect by yourself"));
         setUseEffect(currentFilePath);
-        lifecycleMethods.forEach((lifecycleMethod) => {
+        for (const lifecycleMethod of lifecycleMethods) {
           const lines = this.mutationAdapter.getSource(lifecycleMethod, { fixIndent: true }).split("\n");
           functionBody.push(
             indentCode(
               lines.map((line) => (line.length > 0 ? "// " + line : "//")).join("\n"),
               1,
             ),
           );
-        });
+        }
       }
 
       // render() {}
@@ -218,9 +218,9 @@ ${functionBody.join("\n")}
       () => {
         const tabWidth = this.mutationAdapter.getIndent(this.currentNode) / Synvert.Configuration.tabWidth;
         const body = [];
-        this.currentNode.declarations[0].initializer.body.statements.forEach((statement) => {
+        for (const statement of this.currentNode.declarations[0].initializer.body.statements) {
           body.push(this.mutationAdapter.getSource(statement, { fixIndent: true }));
-        });
+        }
         replaceWith(indentCode(body.join("\n"), tabWidth, { skipFirstLine: true }));
       },
     );