make sure association last argument is a keyword hash

Author: flyerhzm

lib/helpers/parse_rails.rb

@@ -56,9 +56,9 @@
       add_callback :call_node, at: 'start' do |node|
         if node.receiver.nil? && %i[belongs_to has_one has_many has_and_belongs_to_many].include?(node.name)
           association_name = node.arguments.arguments.first.to_value
-          option_elements = node.arguments.arguments.second&.elements
           options = {}
-          if option_elements
+          if node.arguments.arguments.length > 1 && node.arguments.arguments.last.is_a?(Prism::KeywordHashNode)
+            option_elements = node.arguments.arguments.last.elements
             %i[foreign_key foreign_type polymorphic].each do |option_key|
               option_element = option_elements.find { |element| element.key.value == option_key.to_s }
               options[option_key] = option_element.value.to_value if option_element

lib/rails_best_practices/always_add_db_index.rb

@@ -22,7 +22,7 @@
     rails_tables.each do |table_name, table_info|
       belongs_to_associations = rails_models[:associations].select do |association|
         # find all belongs_to associations
-        association[:class_name].tableize == table_name || association[:type] == 'belongs_to'
+        association[:class_name].tableize == table_name && association[:type] == 'belongs_to'
       end
       polymorphic_belongs_to_associations = belongs_to_associations.select do |association|
         next false unless association[:polymorphic]