add rails/prefer_nor_conditions snippet

Author: flyerhzm

lib/rails/prefer_nor_conditions.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+Synvert::Rewriter.new 'rails', 'prefer_nor_conditions' do
+  configure(parser: Synvert::PARSER_PARSER)
+
+  description <<~EOS
+    Prefer NOR conditions
+
+    ```ruby
+    where.not(first_name: nil, last_name: nil)
+    ```
+
+    =>
+
+    ```ruby
+    where.not(first_name: nil).where.not(last_name: nil)
+    ```
+  EOS
+
+  if_gem 'rails', '>= 6.0'
+
+  within_files Synvert::ALL_RUBY_FILES do
+    find_node '.send[receiver=.send[message=where][arguments.size=0]][message=not][arguments.size=1][arguments.0=.hash[pairs.length>1]]' do
+      new_source = node.arguments[0].pairs.map do |pair|
+        "where.not(#{pair.to_source})"
+      end.join('.')
+      replace 'receiver.message', :message, :parentheses, with: new_source
+    end
+  end
+end

lib/rails/upgrade_5_2_to_6_0.rb

@@ -8,6 +8,7 @@
   EOS
 
   add_snippet 'rails', 'convert_update_attributes_to_update'
+  add_snippet 'rails', 'prefer_nor_conditions'
 
   if_gem 'rails', '>= 6.0'
 

spec/rails/prefer_nor_conditions_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Prefer NOR conditions' do
+  let(:rewriter_name) { 'rails/prefer_nor_conditions' }
+  let(:fake_file_path) { 'app/models/user.rb' }
+  let(:test_content) { <<~EOS }
+    where.not(first_name: nil, last_name: nil, email: nil)
+  EOS
+
+  let(:test_rewritten_content) { <<~EOS }
+    where.not(first_name: nil).where.not(last_name: nil).where.not(email: nil)
+  EOS
+
+  include_examples 'convertable'
+end

spec/rails/upgrade_5_2_to_6_0_spec.rb

@@ -21,6 +21,7 @@ class Application < Rails::Application
   EOS
   before do
     load_sub_snippets(%w[rails/convert_update_attributes_to_update])
+    load_sub_snippets(%w[rails/prefer_nor_conditions])
     load_helpers(%w[helpers/set_rails_load_defaults.rb])
   end