add snippet rails/explicitly-render-with-formats

Author: flyerhzm

lib/rails/explicitly-render-with-formats.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+Synvert::Rewriter.new 'rails', 'explicitly-render-with-formats' do
+  configure(parser: Synvert::PRISM_PARSER)
+
+  description <<~EOS
+    It calls render with formats explicitly.
+
+    ```ruby
+    render template: 'index.json'
+    ```
+
+    =>
+
+    ```ruby
+    render template: 'index', foramts: [:json]
+    ```
+  EOS
+
+  if_gem 'active_support', '>= 7.0'
+
+  within_files Synvert::RAILS_CONTROLLER_FILES do
+    find_node ".call_node[receiver=nil][name=render][arguments=.arguments_node[arguments.size=1][arguments.0=.keyword_hash_node]]" do
+      template_value = node.arguments.arguments.first.template_value.to_value
+      if template_value&.split('.')&.size == 2
+        replace 'arguments.arguments.0.template_value', with: "'#{template_value.split('.').first}'"
+        insert "formats: [:#{template_value.split('.').last}]", at: 'end', to: 'arguments.arguments.0', and_comma: true
+      end
+    end
+  end
+end

lib/rails/upgrade_6_1_to_7_0.rb

@@ -7,4 +7,5 @@
   add_snippet 'rails', 'deprecate_errors_as_hash'
   add_snippet 'rails', 'remove_active_support_dependencies_private_api'
   add_snippet 'rails', 'update_active_storage_variant_argument'
+  add_snippet 'rails', 'explicitly-render-with-formats'
 end

lib/rails_best_practices/use_scope_access.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+Synvert::Rewriter.new 'rails_best_practices', 'use_scope_access' do
+  configure(parser: Synvert::PRISM_PARSER)
+
+  description <<~EOS
+    It converts Foo to Bar
+
+    ```ruby
+    Foo
+    ```
+
+    =>
+
+    ```ruby
+    Bar
+    ```
+  EOS
+
+  within_files '**/*.rb' do
+    with_node type: 'const', to_source: 'Foo' do
+      replace_with 'Bar'
+    end
+  end
+end

spec/rails/explicitly-render-with-formats_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Explicitly render with formats' do
+  let(:rewriter_name) { 'rails/explicitly-render-with-formats' }
+  let(:fake_file_path) { 'app/controllers/foo_controller.rb' }
+  let(:test_content) { "render template: 'index.json'" }
+  let(:test_rewritten_content) { "render template: 'index', formats: [:json]" }
+
+  include_examples 'convertable'
+end