forked from rust-lang/docs.rs
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathbuild_queue.rs
1433 lines (1232 loc) · 45 KB
/
build_queue.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
use crate::Context;
use crate::db::{CrateId, Pool, delete_crate, delete_version, update_latest_version_id};
use crate::docbuilder::PackageKind;
use crate::error::Result;
use crate::storage::AsyncStorage;
use crate::utils::{ConfigName, get_config, get_crate_priority, report_error, retry, set_config};
use crate::{BuildPackageSummary, cdn};
use crate::{Config, Index, InstanceMetrics, RustwideBuilder};
use anyhow::Context as _;
use fn_error_context::context;
use futures_util::{StreamExt, stream::TryStreamExt};
use sqlx::Connection as _;
use std::collections::HashMap;
use std::sync::Arc;
use tokio::runtime::Runtime;
use tracing::{debug, error, info, instrument};
/// The static priority for background rebuilds.
/// Used when queueing rebuilds, and when rendering them
/// collapsed in the UI.
/// For normal build priorities we use smaller values.
pub(crate) const REBUILD_PRIORITY: i32 = 20;
#[derive(Debug, Clone, Eq, PartialEq, serde::Serialize)]
pub(crate) struct QueuedCrate {
#[serde(skip)]
id: i32,
pub(crate) name: String,
pub(crate) version: String,
pub(crate) priority: i32,
pub(crate) registry: Option<String>,
}
#[derive(Debug)]
pub struct AsyncBuildQueue {
config: Arc<Config>,
storage: Arc<AsyncStorage>,
pub(crate) db: Pool,
metrics: Arc<InstanceMetrics>,
max_attempts: i32,
}
impl AsyncBuildQueue {
pub fn new(
db: Pool,
metrics: Arc<InstanceMetrics>,
config: Arc<Config>,
storage: Arc<AsyncStorage>,
) -> Self {
AsyncBuildQueue {
max_attempts: config.build_attempts.into(),
config,
db,
metrics,
storage,
}
}
pub async fn last_seen_reference(&self) -> Result<Option<crates_index_diff::gix::ObjectId>> {
let mut conn = self.db.get_async().await?;
if let Some(value) =
get_config::<String>(&mut conn, ConfigName::LastSeenIndexReference).await?
{
return Ok(Some(crates_index_diff::gix::ObjectId::from_hex(
value.as_bytes(),
)?));
}
Ok(None)
}
pub async fn set_last_seen_reference(
&self,
oid: crates_index_diff::gix::ObjectId,
) -> Result<()> {
let mut conn = self.db.get_async().await?;
set_config(
&mut conn,
ConfigName::LastSeenIndexReference,
oid.to_string(),
)
.await?;
Ok(())
}
#[context("error trying to add {name}-{version} to build queue")]
pub async fn add_crate(
&self,
name: &str,
version: &str,
priority: i32,
registry: Option<&str>,
) -> Result<()> {
let mut conn = self.db.get_async().await?;
sqlx::query!(
"INSERT INTO queue (name, version, priority, registry)
VALUES ($1, $2, $3, $4)
ON CONFLICT (name, version) DO UPDATE
SET priority = EXCLUDED.priority,
registry = EXCLUDED.registry,
attempt = 0,
last_attempt = NULL
;",
name,
version,
priority,
registry,
)
.execute(&mut *conn)
.await?;
Ok(())
}
pub(crate) async fn pending_count(&self) -> Result<usize> {
Ok(self
.pending_count_by_priority()
.await?
.values()
.sum::<usize>())
}
pub(crate) async fn prioritized_count(&self) -> Result<usize> {
Ok(self
.pending_count_by_priority()
.await?
.iter()
.filter(|&(&priority, _)| priority <= 0)
.map(|(_, count)| count)
.sum::<usize>())
}
pub(crate) async fn pending_count_by_priority(&self) -> Result<HashMap<i32, usize>> {
let mut conn = self.db.get_async().await?;
Ok(sqlx::query!(
r#"
SELECT
priority,
COUNT(*) as "count!"
FROM queue
WHERE attempt < $1
GROUP BY priority"#,
self.max_attempts,
)
.fetch(&mut *conn)
.map_ok(|row| (row.priority, row.count as usize))
.try_collect()
.await?)
}
pub(crate) async fn failed_count(&self) -> Result<usize> {
let mut conn = self.db.get_async().await?;
Ok(sqlx::query_scalar!(
r#"SELECT COUNT(*) as "count!" FROM queue WHERE attempt >= $1;"#,
self.max_attempts,
)
.fetch_one(&mut *conn)
.await? as usize)
}
pub(crate) async fn queued_crates(&self) -> Result<Vec<QueuedCrate>> {
let mut conn = self.db.get_async().await?;
Ok(sqlx::query_as!(
QueuedCrate,
"SELECT id, name, version, priority, registry
FROM queue
WHERE attempt < $1
ORDER BY priority ASC, attempt ASC, id ASC",
self.max_attempts
)
.fetch_all(&mut *conn)
.await?)
}
pub(crate) async fn has_build_queued(&self, name: &str, version: &str) -> Result<bool> {
let mut conn = self.db.get_async().await?;
Ok(sqlx::query_scalar!(
"SELECT id
FROM queue
WHERE
attempt < $1 AND
name = $2 AND
version = $3
",
self.max_attempts,
name,
version,
)
.fetch_optional(&mut *conn)
.await?
.is_some())
}
}
/// Locking functions.
impl AsyncBuildQueue {
/// Checks for the lock and returns whether it currently exists.
pub async fn is_locked(&self) -> Result<bool> {
let mut conn = self.db.get_async().await?;
Ok(get_config::<bool>(&mut conn, ConfigName::QueueLocked)
.await?
.unwrap_or(false))
}
/// lock the queue. Daemon will check this lock and stop operating if it exists.
pub async fn lock(&self) -> Result<()> {
let mut conn = self.db.get_async().await?;
set_config(&mut conn, ConfigName::QueueLocked, true).await
}
/// unlock the queue.
pub async fn unlock(&self) -> Result<()> {
let mut conn = self.db.get_async().await?;
set_config(&mut conn, ConfigName::QueueLocked, false).await
}
}
/// Index methods.
impl AsyncBuildQueue {
/// Updates registry index repository and adds new crates into build queue.
///
/// Returns the number of crates added
pub async fn get_new_crates(&self, index: &Index) -> Result<usize> {
let diff = index.diff()?;
let last_seen_reference = self
.last_seen_reference()
.await?
.context("no last_seen_reference set in database")?;
diff.set_last_seen_reference(last_seen_reference)?;
let (changes, new_reference) = diff.peek_changes_ordered()?;
let mut conn = self.db.get_async().await?;
let mut crates_added = 0;
debug!("queueing changes from {last_seen_reference} to {new_reference}");
for change in &changes {
if let Some((ref krate, ..)) = change.crate_deleted() {
match delete_crate(&mut conn, &self.storage, &self.config, krate)
.await
.with_context(|| format!("failed to delete crate {krate}"))
{
Ok(_) => info!(
"crate {} was deleted from the index and the database",
krate
),
Err(err) => report_error(&err),
}
if let Err(err) =
cdn::queue_crate_invalidation(&mut conn, &self.config, krate).await
{
report_error(&err);
}
continue;
}
if let Some(release) = change.version_deleted() {
match delete_version(
&mut conn,
&self.storage,
&self.config,
&release.name,
&release.version,
)
.await
.with_context(|| {
format!(
"failed to delete version {}-{}",
release.name, release.version
)
}) {
Ok(_) => info!(
"release {}-{} was deleted from the index and the database",
release.name, release.version
),
Err(err) => report_error(&err),
}
if let Err(err) =
cdn::queue_crate_invalidation(&mut conn, &self.config, &release.name).await
{
report_error(&err);
}
continue;
}
if let Some(release) = change.added() {
let priority = get_crate_priority(&mut conn, &release.name).await?;
match self
.add_crate(
&release.name,
&release.version,
priority,
index.repository_url(),
)
.await
.with_context(|| {
format!(
"failed adding {}-{} into build queue",
release.name, release.version
)
}) {
Ok(()) => {
debug!(
"{}-{} added into build queue",
release.name, release.version
);
self.metrics.queued_builds.inc();
crates_added += 1;
}
Err(err) => report_error(&err),
}
}
let yanked = change.yanked();
let unyanked = change.unyanked();
if let Some(release) = yanked.or(unyanked) {
// FIXME: delay yanks of crates that have not yet finished building
// https://github.com/rust-lang/docs.rs/issues/1934
if let Err(err) = self
.set_yanked_inner(
&mut conn,
release.name.as_str(),
release.version.as_str(),
yanked.is_some(),
)
.await
{
report_error(&err);
}
if let Err(err) =
cdn::queue_crate_invalidation(&mut conn, &self.config, &release.name).await
{
report_error(&err);
}
}
}
// set the reference in the database
// so this survives recreating the registry watcher
// server.
self.set_last_seen_reference(new_reference).await?;
Ok(crates_added)
}
pub async fn set_yanked(&self, name: &str, version: &str, yanked: bool) -> Result<()> {
let mut conn = self.db.get_async().await?;
self.set_yanked_inner(&mut conn, name, version, yanked)
.await
}
#[context("error trying to set {name}-{version} to yanked: {yanked}")]
async fn set_yanked_inner(
&self,
conn: &mut sqlx::PgConnection,
name: &str,
version: &str,
yanked: bool,
) -> Result<()> {
let activity = if yanked { "yanked" } else { "unyanked" };
if let Some(crate_id) = sqlx::query_scalar!(
r#"UPDATE releases
SET yanked = $3
FROM crates
WHERE crates.id = releases.crate_id
AND name = $1
AND version = $2
RETURNING crates.id as "id: CrateId"
"#,
name,
version,
yanked,
)
.fetch_optional(&mut *conn)
.await?
{
debug!("{}-{} {}", name, version, activity);
update_latest_version_id(&mut *conn, crate_id).await?;
} else {
match self
.has_build_queued(name, version)
.await
.context("error trying to fetch build queue")
{
Ok(false) => {
error!(
"tried to yank or unyank non-existing release: {} {}",
name, version
);
}
Ok(true) => {
// the rustwide builder will fetch the current yank state from
// crates.io, so and missed update here will be fixed after the
// build is finished.
}
Err(err) => {
report_error(&err);
}
}
}
Ok(())
}
}
#[derive(Debug)]
pub struct BuildQueue {
runtime: Arc<Runtime>,
inner: Arc<AsyncBuildQueue>,
}
/// sync versions of async methods
impl BuildQueue {
pub fn add_crate(
&self,
name: &str,
version: &str,
priority: i32,
registry: Option<&str>,
) -> Result<()> {
self.runtime
.block_on(self.inner.add_crate(name, version, priority, registry))
}
pub fn set_yanked(&self, name: &str, version: &str, yanked: bool) -> Result<()> {
self.runtime
.block_on(self.inner.set_yanked(name, version, yanked))
}
pub fn is_locked(&self) -> Result<bool> {
self.runtime.block_on(self.inner.is_locked())
}
pub fn lock(&self) -> Result<()> {
self.runtime.block_on(self.inner.lock())
}
pub fn unlock(&self) -> Result<()> {
self.runtime.block_on(self.inner.unlock())
}
pub fn last_seen_reference(&self) -> Result<Option<crates_index_diff::gix::ObjectId>> {
self.runtime.block_on(self.inner.last_seen_reference())
}
pub fn set_last_seen_reference(&self, oid: crates_index_diff::gix::ObjectId) -> Result<()> {
self.runtime
.block_on(self.inner.set_last_seen_reference(oid))
}
#[cfg(test)]
pub(crate) fn pending_count(&self) -> Result<usize> {
self.runtime.block_on(self.inner.pending_count())
}
#[cfg(test)]
pub(crate) fn prioritized_count(&self) -> Result<usize> {
self.runtime.block_on(self.inner.prioritized_count())
}
#[cfg(test)]
pub(crate) fn pending_count_by_priority(&self) -> Result<HashMap<i32, usize>> {
self.runtime
.block_on(self.inner.pending_count_by_priority())
}
#[cfg(test)]
pub(crate) fn failed_count(&self) -> Result<usize> {
self.runtime.block_on(self.inner.failed_count())
}
#[cfg(test)]
pub(crate) fn queued_crates(&self) -> Result<Vec<QueuedCrate>> {
self.runtime.block_on(self.inner.queued_crates())
}
}
impl BuildQueue {
pub fn new(runtime: Arc<Runtime>, inner: Arc<AsyncBuildQueue>) -> Self {
Self { runtime, inner }
}
fn process_next_crate(
&self,
f: impl FnOnce(&QueuedCrate) -> Result<BuildPackageSummary>,
) -> Result<()> {
let mut conn = self.runtime.block_on(self.inner.db.get_async())?;
let mut transaction = self.runtime.block_on(conn.begin())?;
// fetch the next available crate from the queue table.
// We are using `SELECT FOR UPDATE` inside a transaction so
// the QueuedCrate is locked until we are finished with it.
// `SKIP LOCKED` here will enable another build-server to just
// skip over taken (=locked) rows and start building the first
// available one.
let to_process = match self.runtime.block_on(
sqlx::query_as!(
QueuedCrate,
"SELECT id, name, version, priority, registry
FROM queue
WHERE
attempt < $1 AND
(last_attempt IS NULL OR last_attempt < NOW() - make_interval(secs => $2))
ORDER BY priority ASC, attempt ASC, id ASC
LIMIT 1
FOR UPDATE SKIP LOCKED",
self.inner.max_attempts,
self.inner.config.delay_between_build_attempts.as_secs_f64(),
)
.fetch_optional(&mut *transaction),
)? {
Some(krate) => krate,
None => return Ok(()),
};
let res = self
.inner
.metrics
.build_time
.observe_closure_duration(|| f(&to_process));
self.inner.metrics.total_builds.inc();
if let Err(err) = self.runtime.block_on(cdn::queue_crate_invalidation(
&mut transaction,
&self.inner.config,
&to_process.name,
)) {
report_error(&err);
}
let mut increase_attempt_count = || -> Result<()> {
let attempt: i32 = self.runtime.block_on(
sqlx::query_scalar!(
"UPDATE queue
SET
attempt = attempt + 1,
last_attempt = NOW()
WHERE id = $1
RETURNING attempt;",
to_process.id,
)
.fetch_one(&mut *transaction),
)?;
if attempt >= self.inner.max_attempts {
self.inner.metrics.failed_builds.inc();
}
Ok(())
};
match res {
Ok(BuildPackageSummary {
should_reattempt: false,
successful: _,
}) => {
self.runtime.block_on(
sqlx::query!("DELETE FROM queue WHERE id = $1;", to_process.id)
.execute(&mut *transaction),
)?;
}
Ok(BuildPackageSummary {
should_reattempt: true,
successful: _,
}) => {
increase_attempt_count()?;
}
Err(e) => {
increase_attempt_count()?;
report_error(&e.context(format!(
"Failed to build package {}-{} from queue",
to_process.name, to_process.version
)))
}
}
self.runtime.block_on(transaction.commit())?;
Ok(())
}
fn update_toolchain(&self, builder: &mut RustwideBuilder) -> Result<()> {
let updated = retry(
|| {
builder
.update_toolchain()
.context("downloading new toolchain failed")
},
3,
)?;
if updated {
// toolchain has changed, purge caches
retry(
|| {
builder
.purge_caches()
.context("purging rustwide caches failed")
},
3,
)?;
builder
.add_essential_files()
.context("adding essential files failed")?;
}
Ok(())
}
/// Builds the top package from the queue. Returns whether there was a package in the queue.
///
/// Note that this will return `Ok(true)` even if the package failed to build.
pub(crate) fn build_next_queue_package<C: Context>(
&self,
context: &C,
builder: &mut RustwideBuilder,
) -> Result<bool> {
let mut processed = false;
self.process_next_crate(|krate| {
processed = true;
let kind = krate
.registry
.as_ref()
.map(|r| PackageKind::Registry(r.as_str()))
.unwrap_or(PackageKind::CratesIo);
if let Err(err) = retry(
|| {
builder
.reinitialize_workspace_if_interval_passed(context)
.context("Reinitialize workspace failed, locking queue")
},
3,
) {
report_error(&err);
self.lock()?;
return Err(err);
}
if let Err(err) = self
.update_toolchain(&mut *builder)
.context("Updating toolchain failed, locking queue")
{
report_error(&err);
self.lock()?;
return Err(err);
}
builder.build_package(&krate.name, &krate.version, kind)
})?;
Ok(processed)
}
}
/// Queue rebuilds as configured.
///
/// The idea is to rebuild:
/// * the latest release of each crate
/// * when the nightly version is older than our configured threshold
/// * and there was a successful build for that release, that included documentation.
/// * starting with the oldest nightly versions.
/// * also checking if there is already a build queued.
///
/// This might exclude releases from rebuilds that
/// * previously failed but would succeed with a newer nightly version
/// * previously failed but would succeed just with a retry.
#[instrument(skip_all)]
pub async fn queue_rebuilds(
conn: &mut sqlx::PgConnection,
config: &Config,
build_queue: &AsyncBuildQueue,
) -> Result<()> {
let already_queued_rebuilds: usize = build_queue
.pending_count_by_priority()
.await?
.iter()
.filter_map(|(priority, count)| (*priority >= REBUILD_PRIORITY).then_some(count))
.sum();
let rebuilds_to_queue = config
.max_queued_rebuilds
.expect("config.max_queued_rebuilds not set") as i64
- already_queued_rebuilds as i64;
if rebuilds_to_queue <= 0 {
info!("not queueing rebuilds; queue limit reached");
return Ok(());
}
let mut results = sqlx::query!(
"SELECT i.* FROM (
SELECT
c.name,
r.version,
(
SELECT MAX(b.rustc_nightly_date)
FROM builds AS b
WHERE b.rid = r.id AND b.rustc_nightly_date IS NOT NULL
) AS rustc_nightly_date,
(
SELECT MAX(COALESCE(b.build_finished, b.build_started))
FROM builds AS b
WHERE b.rid = r.id
) AS last_build_attempt
FROM crates AS c
INNER JOIN releases AS r ON c.latest_version_id = r.id
WHERE
r.rustdoc_status = TRUE
) as i
WHERE i.rustc_nightly_date < $1
ORDER BY i.last_build_attempt ASC
LIMIT $2",
config
.rebuild_up_to_date
.expect("config.rebuild_up_to_date not set"),
rebuilds_to_queue,
)
.fetch(&mut *conn);
while let Some(row) = results.next().await {
let row = row?;
if !build_queue
.has_build_queued(&row.name, &row.version)
.await?
{
info!("queueing rebuild for {} {}...", &row.name, &row.version);
build_queue
.add_crate(&row.name, &row.version, REBUILD_PRIORITY, None)
.await?;
}
}
Ok(())
}
#[cfg(test)]
mod tests {
use crate::test::FakeBuild;
use super::*;
use chrono::{NaiveDate, Utc};
use std::time::Duration;
#[test]
fn test_dont_rebuild_when_new() {
crate::test::async_wrapper(|env| async move {
env.override_config(|config| {
config.max_queued_rebuilds = Some(100);
config.rebuild_up_to_date = Some(NaiveDate::from_ymd_opt(2020, 1, 1).unwrap());
});
env.fake_release()
.await
.name("foo")
.version("0.1.0")
.builds(vec![
FakeBuild::default()
.rustc_version("rustc 1.84.0-nightly (e7c0d2750 2020-10-15)"),
])
.create()
.await?;
let build_queue = env.async_build_queue().await;
assert!(build_queue.queued_crates().await?.is_empty());
let mut conn = env.async_db().await.async_conn().await;
queue_rebuilds(&mut conn, &env.config(), &build_queue).await?;
assert!(build_queue.queued_crates().await?.is_empty());
Ok(())
})
}
#[test]
fn test_rebuild_when_old() {
crate::test::async_wrapper(|env| async move {
env.override_config(|config| {
config.max_queued_rebuilds = Some(100);
config.rebuild_up_to_date = Some(NaiveDate::from_ymd_opt(2024, 1, 1).unwrap());
});
env.fake_release()
.await
.name("foo")
.version("0.1.0")
.builds(vec![
FakeBuild::default()
.rustc_version("rustc 1.84.0-nightly (e7c0d2750 2020-10-15)"),
])
.create()
.await?;
let build_queue = env.async_build_queue().await;
assert!(build_queue.queued_crates().await?.is_empty());
let mut conn = env.async_db().await.async_conn().await;
queue_rebuilds(&mut conn, &env.config(), &build_queue).await?;
let queue = build_queue.queued_crates().await?;
assert_eq!(queue.len(), 1);
assert_eq!(queue[0].name, "foo");
assert_eq!(queue[0].version, "0.1.0");
assert_eq!(queue[0].priority, REBUILD_PRIORITY);
Ok(())
})
}
#[test]
fn test_still_rebuild_when_full_with_failed() {
crate::test::async_wrapper(|env| async move {
env.override_config(|config| {
config.max_queued_rebuilds = Some(1);
config.rebuild_up_to_date = Some(NaiveDate::from_ymd_opt(2024, 1, 1).unwrap());
});
let build_queue = env.async_build_queue().await;
build_queue
.add_crate("foo1", "0.1.0", REBUILD_PRIORITY, None)
.await?;
build_queue
.add_crate("foo2", "0.1.0", REBUILD_PRIORITY, None)
.await?;
let mut conn = env.async_db().await.async_conn().await;
sqlx::query!("UPDATE queue SET attempt = 99")
.execute(&mut *conn)
.await?;
assert_eq!(build_queue.queued_crates().await?.len(), 0);
env.fake_release()
.await
.name("foo")
.version("0.1.0")
.builds(vec![
FakeBuild::default()
.rustc_version("rustc 1.84.0-nightly (e7c0d2750 2020-10-15)"),
])
.create()
.await?;
let build_queue = env.async_build_queue().await;
queue_rebuilds(&mut conn, &env.config(), &build_queue).await?;
assert_eq!(build_queue.queued_crates().await?.len(), 1);
Ok(())
})
}
#[test]
fn test_dont_rebuild_when_full() {
crate::test::async_wrapper(|env| async move {
env.override_config(|config| {
config.max_queued_rebuilds = Some(1);
config.rebuild_up_to_date = Some(NaiveDate::from_ymd_opt(2024, 1, 1).unwrap());
});
let build_queue = env.async_build_queue().await;
build_queue
.add_crate("foo1", "0.1.0", REBUILD_PRIORITY, None)
.await?;
build_queue
.add_crate("foo2", "0.1.0", REBUILD_PRIORITY, None)
.await?;
env.fake_release()
.await
.name("foo")
.version("0.1.0")
.builds(vec![
FakeBuild::default()
.rustc_version("rustc 1.84.0-nightly (e7c0d2750 2020-10-15)"),
])
.create()
.await?;
let build_queue = env.async_build_queue().await;
assert_eq!(build_queue.queued_crates().await?.len(), 2);
let mut conn = env.async_db().await.async_conn().await;
queue_rebuilds(&mut conn, &env.config(), &build_queue).await?;
assert_eq!(build_queue.queued_crates().await?.len(), 2);
Ok(())
})
}
#[test]
fn test_add_duplicate_doesnt_fail_last_priority_wins() {
crate::test::async_wrapper(|env| async move {
let queue = env.async_build_queue().await;
queue.add_crate("some_crate", "0.1.1", 0, None).await?;
queue.add_crate("some_crate", "0.1.1", 9, None).await?;
let queued_crates = queue.queued_crates().await?;
assert_eq!(queued_crates.len(), 1);
assert_eq!(queued_crates[0].priority, 9);
Ok(())
})
}
#[test]
fn test_add_duplicate_resets_attempts_and_priority() {
crate::test::async_wrapper(|env| async move {
env.override_config(|config| {
config.build_attempts = 5;
});
let queue = env.async_build_queue().await;
let mut conn = env.async_db().await.async_conn().await;
sqlx::query!(
"
INSERT INTO queue (name, version, priority, attempt, last_attempt )
VALUES ('failed_crate', '0.1.1', 0, 99, NOW())",
)
.execute(&mut *conn)
.await?;
assert_eq!(queue.pending_count().await?, 0);
queue.add_crate("failed_crate", "0.1.1", 9, None).await?;
assert_eq!(queue.pending_count().await?, 1);
let row = sqlx::query!(
"SELECT priority, attempt, last_attempt
FROM queue
WHERE name = $1 AND version = $2",
"failed_crate",
"0.1.1",
)
.fetch_one(&mut *conn)
.await?;
assert_eq!(row.priority, 9);
assert_eq!(row.attempt, 0);
assert!(row.last_attempt.is_none());
Ok(())
})
}
#[test]
fn test_has_build_queued() {
crate::test::async_wrapper(|env| async move {
let queue = env.async_build_queue().await;
queue.add_crate("dummy", "0.1.1", 0, None).await?;
let mut conn = env.async_db().await.async_conn().await;
assert!(queue.has_build_queued("dummy", "0.1.1").await.unwrap());
sqlx::query!("UPDATE queue SET attempt = 6")
.execute(&mut *conn)
.await
.unwrap();
assert!(!queue.has_build_queued("dummy", "0.1.1").await.unwrap());
Ok(())
})
}
#[test]
fn test_wait_between_build_attempts() {
crate::test::wrapper(|env| {
env.override_config(|config| {
config.build_attempts = 99;
config.delay_between_build_attempts = Duration::from_secs(1);
});
let runtime = env.runtime();
let queue = env.build_queue();
queue.add_crate("krate", "1.0.0", 0, None)?;
// first let it fail
queue.process_next_crate(|krate| {
assert_eq!(krate.name, "krate");
anyhow::bail!("simulate a failure");
})?;
queue.process_next_crate(|_| {
// this can't happen since we didn't wait between attempts
unreachable!();
})?;
runtime.block_on(async {
// fake the build-attempt timestamp so it's older
let mut conn = env.async_db().await.async_conn().await;