Specify the verbose compilation warnings

Author: jserv

Makefile

@@ -7,23 +7,25 @@ obj-m += xoro.o
 xoro-objs := \
     xoro_mod.o
 
+CFLAGS = -Wall -Werror
+
 GIT_HOOKS := .git/hooks/applied
 
 KDIR := /lib/modules/$(shell uname -r)/build
 PWD := $(shell pwd)
 
-all: $(GIT_HOOKS) user
+all: $(GIT_HOOKS) user test_xoro
 	$(MAKE) -C $(KDIR) M=$(PWD) modules
 
 $(GIT_HOOKS):
 	@scripts/install-git-hooks
 	@echo
 
 user: user.c
-	$(CC) -o $@ $^
+	$(CC) $(CFLAGS) -o $@ $^
 
 test_xoro: test_xoro.c
-	$(CC) -o $@ $^
+	$(CC) $(CFLAGS) -o $@ $^
 
 insmod: all rmmod
 	sudo insmod sort.ko
@@ -33,7 +35,7 @@ rmmod:
 	@sudo rmmod sort 2>/dev/null || echo
 	@sudo rmmod xoro 2>/dev/null || echo
 
-check: user test_xoro
+check: all
 	$(MAKE) insmod
 	sudo ./user
 	sudo ./test_xoro

test_xoro.c

@@ -6,7 +6,7 @@
 #include <unistd.h>
 
 #define MAX_BYTES_PER_READ 8
-static unsigned char rx[MAX_BYTES_PER_READ];  // Receive buffer from the LKM.
+static unsigned char rx[MAX_BYTES_PER_READ]; /* Receive buffer from the LKM */
 
 void zero_rx(void)
 {
@@ -23,12 +23,13 @@ int main(int argc, char *argv[])
         return errno;
     }
 
-    // Test reading different numbers of bytes.
+    /* Test reading different numbers of bytes. */
     for (int n_bytes = 0; n_bytes < 10; n_bytes++) {
-        zero_rx();  // Clear/zero the buffer before copying in read data.
+        /* Clear/zero the buffer before copying in read data. */
+        zero_rx();
 
-        ssize_t n_bytes_read =
-            read(fd, rx, n_bytes);  // Read the response from the LKM
+        /* Read the response from the LKM. */
+        ssize_t n_bytes_read = read(fd, rx, n_bytes);
 
         if (0 > n_bytes_read) {
             perror("Failed to read all bytes.");

user.c

@@ -2,7 +2,6 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 #include <unistd.h>
 
 #define KSORT_DEV "/dev/sort"
@@ -15,13 +14,14 @@ int main()
         goto error;
     }
 
-    size_t nelem = 1000;
-    size_t size = nelem * sizeof(int);
+    size_t n_elements = 1000;
+    size_t size = n_elements * sizeof(int);
     int *inbuf = malloc(size);
     if (!inbuf)
         goto error;
-    for (size_t i = 0; i < nelem; i++)
-        inbuf[i] = rand() % nelem;
+
+    for (size_t i = 0; i < n_elements; i++)
+        inbuf[i] = rand() % n_elements;
 
     ssize_t r_sz = read(fd, inbuf, size);
     if (r_sz != size) {
@@ -32,7 +32,7 @@ int main()
     bool pass = true;
     int ret = 0;
     /* Verify the result of sorting */
-    for (size_t i = 1; i < nelem; i++) {
+    for (size_t i = 1; i < n_elements; i++) {
         if (inbuf[i] < inbuf[i - 1]) {
             pass = false;
             break;