Trivial tweaks to the Worker State Machine (dask#6586)

Author: crusaderky

distributed/tests/test_worker_state_machine.py

@@ -84,8 +84,7 @@ def test_TaskState__to_dict():
 
 
 def test_WorkerState__to_dict():
-    ws = WorkerState(8)
-    ws.address = "127.0.0.1.1234"
+    ws = WorkerState(address="127.0.0.1:1234", transition_counter_max=10)
     ws.handle_stimulus(
         AcquireReplicasEvent(
             who_has={"x": ["127.0.0.1:1235"]}, nbytes={"x": 123}, stimulus_id="s1"
@@ -103,7 +102,7 @@ def test_WorkerState__to_dict():
         del stim["handled"]
 
     expect = {
-        "address": "127.0.0.1.1234",
+        "address": "127.0.0.1:1234",
         "busy_workers": [],
         "constrained": [],
         "data": {"y": None},
@@ -119,7 +118,7 @@ def test_WorkerState__to_dict():
             ["y", "receive-from-scatter", "s2"],
         ],
         "long_running": [],
-        "nthreads": 8,
+        "nthreads": 1,
         "ready": [],
         "running": True,
         "stimulus_log": [

distributed/worker_state_machine.py

@@ -276,10 +276,10 @@ def __repr__(self) -> str:
         return f"<TaskState {self.key!r} {self.state}>"
 
     def __eq__(self, other: object) -> bool:
-        # A task may be forgotten and a new TaskState object with the same key may be created in
-        # its place later on. In the Worker state, you should never have multiple TaskState objects with
-        # the same key. We can't assert it here however, as this comparison is also used in WeakSets
-        # for instance tracking purposes.
+        # A task may be forgotten and a new TaskState object with the same key may be
+        # created in its place later on. In the Worker state, you should never have
+        # multiple TaskState objects with the same key. We can't assert it here however,
+        # as this comparison is also used in WeakSets for instance tracking purposes.
         return other is self
 
     def __hash__(self) -> int:
@@ -1031,8 +1031,8 @@ class WorkerState:
 
     def __init__(
         self,
-        nthreads: int,
         *,
+        nthreads: int = 1,
         address: str | None = None,
         data: MutableMapping[str, Any] = None,
         threads: dict[str, int] | None = None,