Skip to content

duplicate key 'outline' in [type='file']:focus styles #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericbroder opened this issue Mar 29, 2022 · 0 comments · Fixed by #116
Closed

duplicate key 'outline' in [type='file']:focus styles #112

ericbroder opened this issue Mar 29, 2022 · 0 comments · Fixed by #116

Comments

@ericbroder
Copy link

What version of @tailwindcss/forms are you using?

v0.5.0

What version of Node.js are you using?

v16.13.2

What browser are you using?

Chrome

What operating system are you using?

macOS

Reproduction repository

https://github.com/tailwindlabs/tailwindcss-forms

Describe your issue

There is a duplicate key issue with style objects in https://github.com/tailwindlabs/tailwindcss-forms/blob/master/src/index.js#L280

Screen Shot 2022-03-29 at 4 22 32 PM

This can cause some of the styles to not be included in final css output. For more context, see similar issue here:

A possible fix would be to separate them into different array items, such as:

tailwindcss-forms % git diff
diff --git a/src/index.js b/src/index.js
index ee60f72..d5c5da4 100644
--- a/src/index.js
+++ b/src/index.js
@@ -278,6 +278,12 @@ const forms = plugin.withOptions(function (options = { strategy: undefined }) {
         class: null,
         styles: {
           outline: `1px solid ButtonText`,
+        },
+      },
+      {
+        base: [`[type='file']:focus`],
+        class: null,
+        styles: {
           outline: `1px auto -webkit-focus-ring-color`,
         },
       },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant