Handle Ruby %w syntax in Slim pre processing
#17557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/issue-17542
branch
from
669c7a2 to
6902ae2
Compare
thecrypticace
approved these changes
Apr 4, 2025
|
For completeness, I don't think this syntax is valid in Pug (but I could be proven wrong). In Haml you can do it, but we already extract it properly: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Ruby
%w[…]syntax causes utilities to not be properly extracted.This PR will now ensure that it does get extracted correctly.
Given this input:
Before this PR, we extracted everything but the
bg-blue-500. Thew-10was extracted but not because of the second div, but because of the first one.Fixes: #17542
Test plan
Looking at the extractor tool, you can see that it now gets extracted correctly. Top is before, bottom is with this change.