Skip to content

Commit d686aa2

Browse files
ljharbljharb
committed
[eslint] enable quotes rule
1 parent 4526b39 commit d686aa2

14 files changed

+51
-48
lines changed

‎.eslintrc

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"rules": {
44
"indent": ["error", 4],
55
"key-spacing": "error",
6+
"quotes": ["error", "single", {
7+
"avoidEscape": true,
8+
}],
69
"semi": ["error", "always"],
710
"space-before-function-paren": ["error", {
811
"anonymous": "always",

‎test/circular-things.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ tap.test('circular test', function (assert) {
3535
);
3636
}));
3737

38-
test("circular", function (t) {
38+
test('circular', function (t) {
3939
t.plan(1);
4040
var circular = {};
4141
circular.circular = circular;

‎test/comment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ tap.test('non-string types', function (assert) {
130130
t.comment(42);
131131
t.comment(6.66);
132132
t.comment({});
133-
t.comment({"answer": 42});
133+
t.comment({'answer': 42});
134134
function ConstructorFunction() {}
135135
t.comment(new ConstructorFunction());
136136
t.comment(ConstructorFunction);

‎test/create_multiple_streams.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ tape.test('createMultipleStreams', function (tt) {
2323
});
2424

2525
th.onFinish(function () {
26-
tt.equal(th._results.count, 2, "harness test ran");
26+
tt.equal(th._results.count, 2, 'harness test ran');
2727
tt.equal(th._results.fail, 0, "harness test didn't fail");
2828
});
2929
});

‎test/deep-equal-failure.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ tap.test('deep equal failure', function (assert) {
6262
});
6363
});
6464

65-
test("deep equal", function (t) {
65+
test('deep equal', function (t) {
6666
t.plan(1);
6767
t.equal({a: 1}, {b: 2});
6868
});
@@ -123,7 +123,7 @@ tap.test('deep equal failure, depth 6, with option', function (assert) {
123123
});
124124
});
125125

126-
test("deep equal", {objectPrintDepth: 6}, function (t) {
126+
test('deep equal', {objectPrintDepth: 6}, function (t) {
127127
t.plan(1);
128128
t.equal({ a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } }, { a: { a1: { a2: { a3: { a4: { a5: 2 } } } } } });
129129
});
@@ -184,7 +184,7 @@ tap.test('deep equal failure, depth 6, without option', function (assert) {
184184
});
185185
});
186186

187-
test("deep equal", function (t) {
187+
test('deep equal', function (t) {
188188
t.plan(1);
189189
t.equal({ a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } }, { a: { a1: { a2: { a3: { a4: { a5: 2 } } } } } });
190190
});

‎test/end-as-callback.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
var tap = require("tap");
2-
var forEach = require("for-each");
3-
var tape = require("../");
1+
var tap = require('tap');
2+
var forEach = require('for-each');
3+
var tape = require('../');
44
var concat = require('concat-stream');
55

6-
tap.test("tape assert.end as callback", function (tt) {
6+
tap.test('tape assert.end as callback', function (tt) {
77
var test = tape.createHarness({ exit: false });
88

99
test.createStream().pipe(concat(function (rows) {
@@ -26,35 +26,35 @@ tap.test("tape assert.end as callback", function (tt) {
2626
tt.end();
2727
}));
2828

29-
test("do a task and write", function (assert) {
30-
fakeAsyncTask("foo", function (err, value) {
29+
test('do a task and write', function (assert) {
30+
fakeAsyncTask('foo', function (err, value) {
3131
assert.ifError(err);
32-
assert.equal(value, "taskfoo");
32+
assert.equal(value, 'taskfoo');
3333

34-
fakeAsyncWrite("bar", assert.end);
34+
fakeAsyncWrite('bar', assert.end);
3535
});
3636
});
3737

38-
test("do a task and write fail", function (assert) {
39-
fakeAsyncTask("bar", function (err, value) {
38+
test('do a task and write fail', function (assert) {
39+
fakeAsyncTask('bar', function (err, value) {
4040
assert.ifError(err);
41-
assert.equal(value, "taskbar");
41+
assert.equal(value, 'taskbar');
4242

43-
fakeAsyncWriteFail("baz", assert.end);
43+
fakeAsyncWriteFail('baz', assert.end);
4444
});
4545
});
4646
});
4747

4848
function fakeAsyncTask(name, cb) {
49-
cb(null, "task" + name);
49+
cb(null, 'task' + name);
5050
}
5151

5252
function fakeAsyncWrite(name, cb) {
5353
cb(null);
5454
}
5555

5656
function fakeAsyncWriteFail(name, cb) {
57-
cb(new Error("fail"));
57+
cb(new Error('fail'));
5858
}
5959

6060
/**

‎test/not-deep-equal-failure.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ tap.test('deep equal failure', function (assert) {
6262
});
6363
});
6464

65-
test("not deep equal", function (t) {
65+
test('not deep equal', function (t) {
6666
t.plan(1);
6767
t.notDeepEqual({b: 2}, {b: 2});
6868
});
@@ -123,7 +123,7 @@ tap.test('not deep equal failure, depth 6, with option', function (assert) {
123123
});
124124
});
125125

126-
test("not deep equal", {objectPrintDepth: 6}, function (t) {
126+
test('not deep equal', {objectPrintDepth: 6}, function (t) {
127127
t.plan(1);
128128
t.notDeepEqual({ a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } }, { a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } });
129129
});
@@ -184,7 +184,7 @@ tap.test('not deep equal failure, depth 6, without option', function (assert) {
184184
});
185185
});
186186

187-
test("not deep equal", function (t) {
187+
test('not deep equal', function (t) {
188188
t.plan(1);
189189
t.notDeepEqual({ a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } }, { a: { a1: { a2: { a3: { a4: { a5: 1 } } } } } });
190190
});

‎test/not-equal-failure.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ tap.test('not equal failure', function (assert) {
6060
});
6161
});
6262

63-
test("not equal", function (t) {
63+
test('not equal', function (t) {
6464
t.plan(1);
6565
t.notEqual(2, 2);
6666
});

‎test/onFailure.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
1-
var tap = require("tap");
2-
var tape = require("../").createHarness();
1+
var tap = require('tap');
2+
var tape = require('../').createHarness();
33

44
//Because this test passing depends on a failure,
55
//we must direct the failing output of the inner test
66
var noop = function () {};
77
var mockSink = {on: noop, removeListener: noop, emit: noop, end: noop};
88
tape.createStream().pipe(mockSink);
99

10-
tap.test("on failure", { timeout: 1000 }, function (tt) {
10+
tap.test('on failure', { timeout: 1000 }, function (tt) {
1111
tt.plan(1);
1212

13-
tape("dummy test", function (t) {
13+
tape('dummy test', function (t) {
1414
t.fail();
1515
t.end();
1616
});
1717

1818
tape.onFailure(function () {
19-
tt.pass("tape ended");
19+
tt.pass('tape ended');
2020
});
2121
});

‎test/onFinish.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
var tap = require("tap");
2-
var tape = require("../");
1+
var tap = require('tap');
2+
var tape = require('../');
33

4-
tap.test("on finish", {timeout: 1000}, function (tt) {
4+
tap.test('on finish', {timeout: 1000}, function (tt) {
55
tt.plan(1);
66
tape.onFinish(function () {
77
tt.pass('tape ended');

‎test/only-twice.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var tap = require('tap');
44
tap.test('only twice error', function (assert) {
55
var test = tape.createHarness({ exit: false });
66

7-
test.only("first only", function (t) {
7+
test.only('first only', function (t) {
88
t.end();
99
});
1010

‎test/only.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,21 @@ tap.test('tape only test', function (tt) {
2525

2626
test.createStream().pipe(concat(tc));
2727

28-
test("never run fail", function (t) {
28+
test('never run fail', function (t) {
2929
ran.push(1);
3030
t.equal(true, false);
3131
t.end();
3232
});
3333

34-
test("never run success", function (t) {
34+
test('never run success', function (t) {
3535
ran.push(2);
3636
t.equal(true, true);
3737
t.end();
3838
});
3939

40-
test.only("run success", function (t) {
40+
test.only('run success', function (t) {
4141
ran.push(3);
42-
t.ok(true, "assert name");
42+
t.ok(true, 'assert name');
4343
t.end();
4444
});
4545
});

‎test/stackTrace.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ tap.test('preserves stack trace with newlines', function (tt) {
1717
tt.deepEqual(data, {
1818
ok: false,
1919
id: 1,
20-
name: "Error: Preserve stack",
20+
name: 'Error: Preserve stack',
2121
diag: {
2222
stack: stackTrace,
2323
operator: 'error',
@@ -121,7 +121,7 @@ tap.test('preserves stack trace for failed assertions', function (tt) {
121121
tt.deepEqual(data, {
122122
ok: false,
123123
id: 1,
124-
name: "true should be false",
124+
name: 'true should be false',
125125
diag: {
126126
at: at,
127127
stack: stack,
@@ -186,7 +186,7 @@ tap.test('preserves stack trace for failed assertions where actual===falsy', fun
186186
tt.deepEqual(data, {
187187
ok: false,
188188
id: 1,
189-
name: "false should be true",
189+
name: 'false should be true',
190190
diag: {
191191
at: at,
192192
stack: stack,

‎test/throws.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ tap.test('failures', function (tt) {
3939
+ ' expected: |-\n'
4040
+ ' undefined\n'
4141
+ ' actual: |-\n'
42-
+ " { [TypeError: " + getNonFunctionMessage() + "] message: '" + getNonFunctionMessage() + "' }\n"
42+
+ ' { [TypeError: ' + getNonFunctionMessage() + "] message: '" + getNonFunctionMessage() + "' }\n"
4343
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
4444
+ ' stack: |-\n'
4545
+ ' TypeError: ' + getNonFunctionMessage(undefined) + '\n'
@@ -53,7 +53,7 @@ tap.test('failures', function (tt) {
5353
+ ' expected: |-\n'
5454
+ ' undefined\n'
5555
+ ' actual: |-\n'
56-
+ " { [TypeError: " + getNonFunctionMessage(null) + "] message: '" + getNonFunctionMessage(null) + "' }\n"
56+
+ ' { [TypeError: ' + getNonFunctionMessage(null) + "] message: '" + getNonFunctionMessage(null) + "' }\n"
5757
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
5858
+ ' stack: |-\n'
5959
+ ' TypeError: ' + getNonFunctionMessage(null) + '\n'
@@ -67,7 +67,7 @@ tap.test('failures', function (tt) {
6767
+ ' expected: |-\n'
6868
+ ' undefined\n'
6969
+ ' actual: |-\n'
70-
+ " { [TypeError: " + getNonFunctionMessage(true) + "] message: '" + getNonFunctionMessage(true) + "' }\n"
70+
+ ' { [TypeError: ' + getNonFunctionMessage(true) + "] message: '" + getNonFunctionMessage(true) + "' }\n"
7171
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
7272
+ ' stack: |-\n'
7373
+ ' TypeError: ' + getNonFunctionMessage(true) + '\n'
@@ -81,7 +81,7 @@ tap.test('failures', function (tt) {
8181
+ ' expected: |-\n'
8282
+ ' undefined\n'
8383
+ ' actual: |-\n'
84-
+ " { [TypeError: " + getNonFunctionMessage(false) + "] message: '" + getNonFunctionMessage(false) + "' }\n"
84+
+ ' { [TypeError: ' + getNonFunctionMessage(false) + "] message: '" + getNonFunctionMessage(false) + "' }\n"
8585
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
8686
+ ' stack: |-\n'
8787
+ ' TypeError: ' + getNonFunctionMessage(false) + '\n'
@@ -95,7 +95,7 @@ tap.test('failures', function (tt) {
9595
+ ' expected: |-\n'
9696
+ ' undefined\n'
9797
+ ' actual: |-\n'
98-
+ " { [TypeError: " + getNonFunctionMessage('abc') + "] message: '" + getNonFunctionMessage('abc') + "' }\n"
98+
+ ' { [TypeError: ' + getNonFunctionMessage('abc') + "] message: '" + getNonFunctionMessage('abc') + "' }\n"
9999
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
100100
+ ' stack: |-\n'
101101
+ ' TypeError: ' + getNonFunctionMessage('abc') + '\n'
@@ -109,7 +109,7 @@ tap.test('failures', function (tt) {
109109
+ ' expected: |-\n'
110110
+ ' undefined\n'
111111
+ ' actual: |-\n'
112-
+ " { [TypeError: " + getNonFunctionMessage(/a/g) + "] message: '" + getNonFunctionMessage(/a/g) + "' }\n"
112+
+ ' { [TypeError: ' + getNonFunctionMessage(/a/g) + "] message: '" + getNonFunctionMessage(/a/g) + "' }\n"
113113
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
114114
+ ' stack: |-\n'
115115
+ ' TypeError: ' + getNonFunctionMessage(/a/g) + '\n'
@@ -123,7 +123,7 @@ tap.test('failures', function (tt) {
123123
+ ' expected: |-\n'
124124
+ ' undefined\n'
125125
+ ' actual: |-\n'
126-
+ " { [TypeError: " + getNonFunctionMessage([]) + "] message: '" + getNonFunctionMessage([]) + "' }\n"
126+
+ ' { [TypeError: ' + getNonFunctionMessage([]) + "] message: '" + getNonFunctionMessage([]) + "' }\n"
127127
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
128128
+ ' stack: |-\n'
129129
+ ' TypeError: ' + getNonFunctionMessage([]) + '\n'
@@ -137,7 +137,7 @@ tap.test('failures', function (tt) {
137137
+ ' expected: |-\n'
138138
+ ' undefined\n'
139139
+ ' actual: |-\n'
140-
+ " { [TypeError: " + getNonFunctionMessage({}) + "] message: '" + getNonFunctionMessage({}) + "' }\n"
140+
+ ' { [TypeError: ' + getNonFunctionMessage({}) + "] message: '" + getNonFunctionMessage({}) + "' }\n"
141141
+ ' at: Test.<anonymous> ($TEST/throws.js:$LINE:$COL)\n'
142142
+ ' stack: |-\n'
143143
+ ' TypeError: ' + getNonFunctionMessage({}) + '\n'

0 commit comments

Comments
 (0)