Assert on several primary indexes

Author: Totktonada

graphql/accessor_general.lua

@@ -112,14 +112,26 @@ local function get_primary_index_meta(self, collection_name)
         type(collection_name))
 
     local indexes = self.indexes[collection_name]
+
+    local res_index_name
+
     for index_name, index in pairs(indexes) do
-        if index.primary then
-            return index_name, index
+        if res_index_name == nil and index.primary then
+            res_index_name = index_name
+        elseif res_index_name ~= nil and index.primary then
+            error(('several indexes were marked as primary in ' ..
+                'the "%s" collection, at least "%s" and "%s"'):format(
+                collection_name, res_index_name, index_name))
         end
     end
 
-    error(('cannot find primary index for collection "%s"'):format(
-        collection_name))
+    if res_index_name == nil then
+        error(('cannot find primary index for collection "%s"'):format(
+            collection_name))
+    end
+
+    local res_index = indexes[res_index_name]
+    return res_index_name, res_index
 end
 
 --- Get a key to lookup index by `lookup_index_name` (part of `index_cache`).

test/local/init_fail.result

@@ -1,2 +1,3 @@
 INIT: ok: false; err: 1:1 connection "user_connection" of collection "order_collection" has less fields than the index of "user_str_num_index" collection (cannot prove uniqueness of the partial index)
 INIT: ok: true; type(res): table
+INIT: ok: false; err: several indexes were marked as primary in the "user_collection" collection, at least "user_str_index" and "user_str_num_index"

test/local/init_fail.test.lua

@@ -54,7 +54,6 @@ local function create_gql_wrapper(metadata)
         collections = metadata.collections,
         accessor = accessor,
     })
-
 end
 
 local ok, err = pcall(create_gql_wrapper, metadata)
@@ -66,6 +65,24 @@ metadata.collections.order_collection.connections[1].parts[2] = saved_part
 local ok, res = pcall(create_gql_wrapper, metadata)
 print(('INIT: ok: %s; type(res): %s'):format(tostring(ok), type(res)))
 
+-- multiple primary indexes
+-- ------------------------
+
+-- inject an error into the metadata
+metadata.indexes.user_collection.user_str_index = {
+    service_fields = {},
+    fields = {'user_str'},
+    index_type = 'tree',
+    unique = true,
+    primary = true,
+}
+
+local ok, err = pcall(create_gql_wrapper, metadata)
+print(('INIT: ok: %s; err: %s'):format(tostring(ok), strip_error(err)))
+
+-- restore metadata back
+metadata.indexes.user_collection.user_str_index = nil
+
 -- clean up
 -- --------