Added installation on macos #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Aug 9, 2021
| async function run_macos(): Promise<void> { | ||
| try { | ||
| core.startGroup('Installing tarantool') | ||
| await exec.exec(`brew install tarantool`) |
There was a problem hiding this comment.
- If I asked one version (say, 1.10) I may silently get another one?
- How about caching?
Without caching and version choosing there is no much sense in the action: I can just use brew install tarantool directly.
Don't know, whether it'll actual for you, but if you'll build tarantool from sources on Mac OS 11, you should workaround tarantool/tarantool#6076: remove src/lib/small/VERSION and disable generation of VERSION file in tarantool (see CMakeLists.txt:251).
|
I'll close the pull request, because it is stalled for almost a year. Feel free to re-open if you want to continue to work on it. For a while I can share how we run testing against tarantool on Mac OS as current workaround. It lacks the nice caching, but does the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10