Skip to content

Commit 178337c

Browse files
committed
Soft automatic schema reload
Now client keeps actual schema metadata and sends schemaId header to be checked against current Tarantool schema version. If client version mismatches DB version client does schema reloading in the background. Client operation interface was reworked in scope of support not only number identifiers for spaces and indexes but also their string names. Closes: #7, #137
1 parent b53e0ba commit 178337c

27 files changed

+1436
-205
lines changed

Diff for: README.md

+12
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,18 @@ makes possible for the client to configure a socket provider.
122122
* `ComposableAsyncOps` - return the operation result as a `CompletionStage`
123123
* `FireAndForgetOps` - returns the query ID
124124

125+
Each operation that requires space or index to be executed, can work with
126+
number ID as well as string name of a space or an index.
127+
Assume, we have `my_space` space with space ID `512` and its primary index
128+
`primary` with index ID `0`. Then, for instance, `select` operations can be
129+
performed as the following:
130+
131+
```java
132+
client.syncOps().select(512, 0, Collections.singletonList(1), 0, 1, Iterator.EQ);
133+
// or using more convenient way
134+
client.syncOps().select("my_space", "primary", Collections.singletonList(1), 0, 1, Iterator.EQ);
135+
```
136+
125137
Feel free to override any method of `TarantoolClientImpl`. For example, to hook
126138
all the results, you could override this:
127139

+178-23
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,217 @@
11
package org.tarantool;
22

3+
import static org.tarantool.AbstractTarantoolOps.ResolvableArgument.ofResolved;
4+
import static org.tarantool.AbstractTarantoolOps.ResolvableArgument.ofUnresolved;
35

4-
public abstract class AbstractTarantoolOps<Space, Tuple, Operation, Result>
5-
implements TarantoolClientOps<Space, Tuple, Operation, Result> {
6+
import java.util.Objects;
7+
import java.util.function.Function;
8+
import java.util.stream.Stream;
9+
10+
public abstract class AbstractTarantoolOps<Tuple, Operation, Result>
11+
implements TarantoolClientOps<Tuple, Operation, Result> {
12+
13+
private final Function<Object, Object> defaultSpaceResolver = space -> resolveSpace((String) space);
614

715
private Code callCode = Code.CALL;
816

9-
protected abstract Result exec(Code code, Object... args);
17+
protected Result exec(Code code, Object... args) {
18+
return exec(code, ResolvableArgument.ofAllResolved(args));
19+
}
20+
21+
protected abstract Result exec(Code code, ResolvableArgument... args);
22+
23+
protected abstract int resolveSpace(String space);
24+
25+
protected abstract int resolveSpaceIndex(String space, String index);
26+
27+
protected static class ResolvableArgument {
28+
29+
private final Object value;
30+
private final Function<Object, Object> resolver;
31+
32+
private ResolvableArgument(Object value, Function<Object, Object> resolver) {
33+
Objects.requireNonNull(value);
34+
this.value = value;
35+
this.resolver = resolver;
36+
}
37+
38+
public static ResolvableArgument ofResolved(Object resolvedValue) {
39+
return new ResolvableArgument(resolvedValue, null);
40+
}
41+
42+
public static ResolvableArgument[] ofAllResolved(Object[] resolvedValue) {
43+
return Stream.of(resolvedValue).map(ResolvableArgument::ofResolved).toArray(ResolvableArgument[]::new);
44+
}
45+
46+
public static ResolvableArgument ofUnresolved(Object unresolvedValue, Function<Object, Object> resolver) {
47+
return new ResolvableArgument(unresolvedValue, resolver);
48+
}
49+
50+
public boolean isUnresolved() {
51+
try {
52+
return isResolvable() && resolver.apply(value) == null;
53+
} catch (Exception ignored) {
54+
return true;
55+
}
56+
}
57+
58+
public boolean isResolvable() {
59+
return resolver != null;
60+
}
1061

11-
public Result select(Space space, Space index, Tuple key, int offset, int limit, Iterator iterator) {
62+
public Object getValue() {
63+
return isResolvable() ? resolver.apply(value) : value;
64+
}
65+
66+
@Override
67+
public String toString() {
68+
if (isUnresolved()) {
69+
return "{unresolved: " + value + "}";
70+
}
71+
return value.toString();
72+
}
73+
74+
}
75+
76+
@Override
77+
public Result select(Integer space, Integer index, Tuple key, int offset, int limit, Iterator iterator) {
1278
return select(space, index, key, offset, limit, iterator.getValue());
1379
}
1480

15-
public Result select(Space space, Space index, Tuple key, int offset, int limit, int iterator) {
16-
return exec(
17-
Code.SELECT,
18-
Key.SPACE, space,
19-
Key.INDEX, index,
20-
Key.KEY, key,
21-
Key.ITERATOR, iterator,
22-
Key.LIMIT, limit,
23-
Key.OFFSET, offset
81+
@Override
82+
public Result select(String space, String index, Tuple key, int offset, int limit, Iterator iterator) {
83+
return select(space, index, key, offset, limit, iterator.getValue());
84+
}
85+
86+
@Override
87+
public Result select(Integer space, Integer index, Tuple key, int offset, int limit, int iterator) {
88+
return doSelect(ofResolved(space), ofResolved(index), key, offset, limit, iterator);
89+
}
90+
91+
@Override
92+
public Result select(String space, String index, Tuple key, int offset, int limit, int iterator) {
93+
return doSelect(
94+
ofUnresolved(space, defaultSpaceResolver),
95+
ofUnresolved(index, indexName -> resolveSpaceIndex(space, (String) indexName)),
96+
key, offset, limit, iterator
2497
);
2598
}
2699

27-
public Result insert(Space space, Tuple tuple) {
28-
return exec(Code.INSERT, Key.SPACE, space, Key.TUPLE, tuple);
100+
@Override
101+
public Result insert(Integer space, Tuple tuple) {
102+
return doInsert(ofResolved(space), tuple);
29103
}
30104

31-
public Result replace(Space space, Tuple tuple) {
32-
return exec(Code.REPLACE, Key.SPACE, space, Key.TUPLE, tuple);
105+
@Override
106+
public Result insert(String space, Tuple tuple) {
107+
return doInsert(ofUnresolved(space, defaultSpaceResolver), tuple);
33108
}
34109

35-
public Result update(Space space, Tuple key, Operation... args) {
36-
return exec(Code.UPDATE, Key.SPACE, space, Key.KEY, key, Key.TUPLE, args);
110+
@Override
111+
public Result replace(Integer space, Tuple tuple) {
112+
return doReplace(ofResolved(space), tuple);
37113
}
38114

39-
public Result upsert(Space space, Tuple key, Tuple def, Operation... args) {
40-
return exec(Code.UPSERT, Key.SPACE, space, Key.KEY, key, Key.TUPLE, def, Key.UPSERT_OPS, args);
115+
@Override
116+
public Result replace(String space, Tuple tuple) {
117+
return doReplace(ofUnresolved(space, defaultSpaceResolver), tuple);
41118
}
42119

43-
public Result delete(Space space, Tuple key) {
44-
return exec(Code.DELETE, Key.SPACE, space, Key.KEY, key);
120+
@Override
121+
public Result update(Integer space, Tuple key, Operation... args) {
122+
return doUpdate(ofResolved(space), key, args);
45123
}
46124

125+
@Override
126+
public Result update(String space, Tuple key, Operation... tuple) {
127+
return doUpdate(ofUnresolved(space, defaultSpaceResolver), key, tuple);
128+
}
129+
130+
@Override
131+
public Result upsert(Integer space, Tuple key, Tuple defTuple, Operation... ops) {
132+
return doUpsert(ofResolved(space), key, defTuple, ops);
133+
}
134+
135+
@Override
136+
public Result upsert(String space, Tuple key, Tuple defTuple, Operation... ops) {
137+
return doUpsert(ofUnresolved(space, defaultSpaceResolver), key, defTuple, ops);
138+
}
139+
140+
@Override
141+
public Result delete(Integer space, Tuple key) {
142+
return doDelete(ofResolved(space), key);
143+
}
144+
145+
@Override
146+
public Result delete(String space, Tuple key) {
147+
return doDelete(ofUnresolved(space, defaultSpaceResolver), key);
148+
}
149+
150+
@Override
47151
public Result call(String function, Object... args) {
48152
return exec(callCode, Key.FUNCTION, function, Key.TUPLE, args);
49153
}
50154

155+
@Override
51156
public Result eval(String expression, Object... args) {
52157
return exec(Code.EVAL, Key.EXPRESSION, expression, Key.TUPLE, args);
53158
}
54159

160+
@Override
55161
public void ping() {
56162
exec(Code.PING);
57163
}
58164

59165
public void setCallCode(Code callCode) {
60166
this.callCode = callCode;
61167
}
168+
169+
private Result doDelete(ResolvableArgument space, Tuple key) {
170+
return exec(Code.DELETE, ofResolved(Key.SPACE), space, ofResolved(Key.KEY), ofResolved(key));
171+
}
172+
173+
private Result doUpsert(ResolvableArgument space, Tuple key, Tuple defTuple, Operation... ops) {
174+
return exec(
175+
Code.UPSERT,
176+
ofResolved(Key.SPACE), space,
177+
ofResolved(Key.KEY), ofResolved(key),
178+
ofResolved(Key.TUPLE), ofResolved(defTuple),
179+
ofResolved(Key.UPSERT_OPS), ofResolved(ops)
180+
);
181+
}
182+
183+
private Result doUpdate(ResolvableArgument space, Tuple key, Operation... ops) {
184+
return exec(
185+
Code.UPDATE,
186+
ofResolved(Key.SPACE), space,
187+
ofResolved(Key.KEY), ofResolved(key),
188+
ofResolved(Key.TUPLE), ofResolved(ops)
189+
);
190+
}
191+
192+
private Result doReplace(ResolvableArgument space, Tuple tuple) {
193+
return exec(Code.REPLACE, ofResolved(Key.SPACE), space, ofResolved(Key.TUPLE), ofResolved(tuple));
194+
}
195+
196+
private Result doInsert(ResolvableArgument space, Tuple tuple) {
197+
return exec(Code.INSERT, ofResolved(Key.SPACE), space, ofResolved(Key.TUPLE), ofResolved(tuple));
198+
}
199+
200+
private Result doSelect(ResolvableArgument space,
201+
ResolvableArgument index,
202+
Tuple key,
203+
int offset,
204+
int limit,
205+
int iterator) {
206+
return exec(
207+
Code.SELECT,
208+
ofResolved(Key.SPACE), space,
209+
ofResolved(Key.INDEX), index,
210+
ofResolved(Key.KEY), ofResolved(key),
211+
ofResolved(Key.ITERATOR), ofResolved(iterator),
212+
ofResolved(Key.LIMIT), ofResolved(limit),
213+
ofResolved(Key.OFFSET), ofResolved(offset)
214+
);
215+
}
216+
62217
}

Diff for: src/main/java/org/tarantool/TarantoolBase.java

+1-11
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import java.util.List;
1010
import java.util.concurrent.atomic.AtomicLong;
1111

12-
public abstract class TarantoolBase<Result> extends AbstractTarantoolOps<Integer, List<?>, Object, Result> {
12+
public abstract class TarantoolBase<Result> extends AbstractTarantoolOps<List<?>, Object, Result> {
1313
protected String serverVersion;
1414
protected MsgPackLite msgPackLite = MsgPackLite.INSTANCE;
1515
protected AtomicLong syncId = new AtomicLong();
@@ -42,16 +42,6 @@ protected void closeChannel(SocketChannel channel) {
4242
}
4343
}
4444

45-
protected void validateArgs(Object[] args) {
46-
if (args != null) {
47-
for (int i = 0; i < args.length; i += 2) {
48-
if (args[i + 1] == null) {
49-
throw new NullPointerException(((Key) args[i]).name() + " should not be null");
50-
}
51-
}
52-
}
53-
}
54-
5545
public void setInitialRequestSize(int initialRequestSize) {
5646
this.initialRequestSize = initialRequestSize;
5747
}

Diff for: src/main/java/org/tarantool/TarantoolClient.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
import java.util.concurrent.TimeUnit;
88

99
public interface TarantoolClient {
10-
TarantoolClientOps<Integer, List<?>, Object, List<?>> syncOps();
10+
TarantoolClientOps<List<?>, Object, List<?>> syncOps();
1111

12-
TarantoolClientOps<Integer, List<?>, Object, Future<List<?>>> asyncOps();
12+
TarantoolClientOps<List<?>, Object, Future<List<?>>> asyncOps();
1313

14-
TarantoolClientOps<Integer, List<?>, Object, CompletionStage<List<?>>> composableAsyncOps();
14+
TarantoolClientOps<List<?>, Object, CompletionStage<List<?>>> composableAsyncOps();
1515

16-
TarantoolClientOps<Integer, List<?>, Object, Long> fireAndForgetOps();
16+
TarantoolClientOps<List<?>, Object, Long> fireAndForgetOps();
1717

1818
TarantoolSQLOps<Object, Long, List<Map<String, Object>>> sqlSyncOps();
1919

0 commit comments

Comments
 (0)