Skip to content

Commit 51ed9ea

Browse files
committed
Soft automatic schema reload
Now client keeps actual schema metadata and sends schemaId header to be checked against current Tarantool schema version. If client version mismatches DB version client does schema reloading in the background. Client operation interface was reworked in scope of support not only number identifiers for spaces and indexes but also their string names. Closes: #7, #137
1 parent 2473ffa commit 51ed9ea

27 files changed

+1376
-205
lines changed

Diff for: README.md

+12
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,18 @@ makes possible for the client to configure a socket provider.
122122
* `ComposableAsyncOps` - return the operation result as a `CompletionStage`
123123
* `FireAndForgetOps` - returns the query ID
124124

125+
Each operation that requires space or index to be executed, can work with
126+
number ID as well as string name of a space or an index.
127+
Assume, we have `my_space` space with space ID `512` and its primary index
128+
`primary` with index ID `0`. Then, for instance, `select` operations can be
129+
performed as the following:
130+
131+
```java
132+
client.syncOps().select(512, 0, Collections.singletonList(1), 0, 1, Iterator.EQ);
133+
// or using more convenient way
134+
client.syncOps().select("my_space", "primary", Collections.singletonList(1), 0, 1, Iterator.EQ);
135+
```
136+
125137
Feel free to override any method of `TarantoolClientImpl`. For example, to hook
126138
all the results, you could override this:
127139

+174-23
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,213 @@
11
package org.tarantool;
22

3+
import static org.tarantool.AbstractTarantoolOps.ResolvableArgument.ofResolved;
4+
import static org.tarantool.AbstractTarantoolOps.ResolvableArgument.ofUnresolved;
35

4-
public abstract class AbstractTarantoolOps<Space, Tuple, Operation, Result>
5-
implements TarantoolClientOps<Space, Tuple, Operation, Result> {
6+
import java.util.Objects;
7+
import java.util.function.Function;
8+
import java.util.stream.Stream;
9+
10+
public abstract class AbstractTarantoolOps<Tuple, Operation, Result>
11+
implements TarantoolClientOps<Tuple, Operation, Result> {
12+
13+
private final Function<Object, Object> defaultSpaceResolver = space -> resolveSpace((String) space);
614

715
private Code callCode = Code.OLD_CALL;
816

9-
protected abstract Result exec(Code code, Object... args);
17+
protected Result exec(Code code, Object... args) {
18+
return exec(code, ResolvableArgument.ofAllResolved(args));
19+
}
20+
21+
protected abstract Result exec(Code code, ResolvableArgument... args);
22+
23+
protected abstract int resolveSpace(String space);
24+
25+
protected abstract int resolveSpaceIndex(String space, String index);
26+
27+
protected static class ResolvableArgument {
28+
29+
private final Object value;
30+
private final Function<Object, Object> resolver;
31+
32+
private ResolvableArgument(Object value, Function<Object, Object> resolver) {
33+
Objects.requireNonNull(value);
34+
this.value = value;
35+
this.resolver = resolver;
36+
}
37+
38+
public static ResolvableArgument ofResolved(Object resolvedValue) {
39+
return new ResolvableArgument(resolvedValue, null);
40+
}
41+
42+
public static ResolvableArgument[] ofAllResolved(Object[] resolvedValue) {
43+
return Stream.of(resolvedValue).map(ResolvableArgument::ofResolved).toArray(ResolvableArgument[]::new);
44+
}
45+
46+
public static ResolvableArgument ofUnresolved(Object unresolvedValue, Function<Object, Object> resolver) {
47+
return new ResolvableArgument(unresolvedValue, resolver);
48+
}
49+
50+
public boolean isUnresolved() {
51+
try {
52+
return resolver != null && resolver.apply(value) == null;
53+
} catch (Exception ignored) {
54+
return true;
55+
}
56+
}
57+
58+
public Object getValue() {
59+
return resolver != null ? resolver.apply(value) : value;
60+
}
1061

11-
public Result select(Space space, Space index, Tuple key, int offset, int limit, Iterator iterator) {
62+
@Override
63+
public String toString() {
64+
if (isUnresolved()) {
65+
return "{unresolved: " + value + "}";
66+
}
67+
return value.toString();
68+
}
69+
70+
}
71+
72+
@Override
73+
public Result select(Integer space, Integer index, Tuple key, int offset, int limit, Iterator iterator) {
1274
return select(space, index, key, offset, limit, iterator.getValue());
1375
}
1476

15-
public Result select(Space space, Space index, Tuple key, int offset, int limit, int iterator) {
16-
return exec(
17-
Code.SELECT,
18-
Key.SPACE, space,
19-
Key.INDEX, index,
20-
Key.KEY, key,
21-
Key.ITERATOR, iterator,
22-
Key.LIMIT, limit,
23-
Key.OFFSET, offset
77+
@Override
78+
public Result select(String space, String index, Tuple key, int offset, int limit, Iterator iterator) {
79+
return select(space, index, key, offset, limit, iterator.getValue());
80+
}
81+
82+
@Override
83+
public Result select(Integer space, Integer index, Tuple key, int offset, int limit, int iterator) {
84+
return doSelect(ofResolved(space), ofResolved(index), key, offset, limit, iterator);
85+
}
86+
87+
@Override
88+
public Result select(String space, String index, Tuple key, int offset, int limit, int iterator) {
89+
return doSelect(
90+
ofUnresolved(space, defaultSpaceResolver),
91+
ofUnresolved(index, indexName -> resolveSpaceIndex(space, (String) indexName)),
92+
key, offset, limit, iterator
2493
);
2594
}
2695

27-
public Result insert(Space space, Tuple tuple) {
28-
return exec(Code.INSERT, Key.SPACE, space, Key.TUPLE, tuple);
96+
@Override
97+
public Result insert(Integer space, Tuple tuple) {
98+
return doInsert(ofResolved(space), tuple);
99+
}
100+
101+
@Override
102+
public Result insert(String space, Tuple tuple) {
103+
return doInsert(ofUnresolved(space, defaultSpaceResolver), tuple);
104+
}
105+
106+
@Override
107+
public Result replace(Integer space, Tuple tuple) {
108+
return doReplace(ofResolved(space), tuple);
109+
}
110+
111+
@Override
112+
public Result replace(String space, Tuple tuple) {
113+
return doReplace(ofUnresolved(space, defaultSpaceResolver), tuple);
114+
}
115+
116+
@Override
117+
public Result update(Integer space, Tuple key, Operation... args) {
118+
return doUpdate(ofResolved(space), key, args);
119+
}
120+
121+
@Override
122+
public Result update(String space, Tuple key, Operation... tuple) {
123+
return doUpdate(ofUnresolved(space, defaultSpaceResolver), key, tuple);
29124
}
30125

31-
public Result replace(Space space, Tuple tuple) {
32-
return exec(Code.REPLACE, Key.SPACE, space, Key.TUPLE, tuple);
126+
@Override
127+
public Result upsert(Integer space, Tuple key, Tuple defTuple, Operation... ops) {
128+
return doUpsert(ofResolved(space), key, defTuple, ops);
33129
}
34130

35-
public Result update(Space space, Tuple key, Operation... args) {
36-
return exec(Code.UPDATE, Key.SPACE, space, Key.KEY, key, Key.TUPLE, args);
131+
@Override
132+
public Result upsert(String space, Tuple key, Tuple defTuple, Operation... ops) {
133+
return doUpsert(ofUnresolved(space, defaultSpaceResolver), key, defTuple, ops);
37134
}
38135

39-
public Result upsert(Space space, Tuple key, Tuple def, Operation... args) {
40-
return exec(Code.UPSERT, Key.SPACE, space, Key.KEY, key, Key.TUPLE, def, Key.UPSERT_OPS, args);
136+
@Override
137+
public Result delete(Integer space, Tuple key) {
138+
return doDelete(ofResolved(space), key);
41139
}
42140

43-
public Result delete(Space space, Tuple key) {
44-
return exec(Code.DELETE, Key.SPACE, space, Key.KEY, key);
141+
@Override
142+
public Result delete(String space, Tuple key) {
143+
return doDelete(ofUnresolved(space, defaultSpaceResolver), key);
45144
}
46145

146+
@Override
47147
public Result call(String function, Object... args) {
48148
return exec(callCode, Key.FUNCTION, function, Key.TUPLE, args);
49149
}
50150

151+
@Override
51152
public Result eval(String expression, Object... args) {
52153
return exec(Code.EVAL, Key.EXPRESSION, expression, Key.TUPLE, args);
53154
}
54155

156+
@Override
55157
public void ping() {
56158
exec(Code.PING);
57159
}
58160

59161
public void setCallCode(Code callCode) {
60162
this.callCode = callCode;
61163
}
164+
165+
private Result doDelete(ResolvableArgument space, Tuple key) {
166+
return exec(Code.DELETE, ofResolved(Key.SPACE), space, ofResolved(Key.KEY), ofResolved(key));
167+
}
168+
169+
private Result doUpsert(ResolvableArgument space, Tuple key, Tuple defTuple, Operation... ops) {
170+
return exec(
171+
Code.UPSERT,
172+
ofResolved(Key.SPACE), space,
173+
ofResolved(Key.KEY), ofResolved(key),
174+
ofResolved(Key.TUPLE), ofResolved(defTuple),
175+
ofResolved(Key.UPSERT_OPS), ofResolved(ops)
176+
);
177+
}
178+
179+
private Result doUpdate(ResolvableArgument space, Tuple key, Operation... ops) {
180+
return exec(
181+
Code.UPDATE,
182+
ofResolved(Key.SPACE), space,
183+
ofResolved(Key.KEY), ofResolved(key),
184+
ofResolved(Key.TUPLE), ofResolved(ops)
185+
);
186+
}
187+
188+
private Result doReplace(ResolvableArgument space, Tuple tuple) {
189+
return exec(Code.REPLACE, ofResolved(Key.SPACE), space, ofResolved(Key.TUPLE), ofResolved(tuple));
190+
}
191+
192+
private Result doInsert(ResolvableArgument space, Tuple tuple) {
193+
return exec(Code.INSERT, ofResolved(Key.SPACE), space, ofResolved(Key.TUPLE), ofResolved(tuple));
194+
}
195+
196+
private Result doSelect(ResolvableArgument space,
197+
ResolvableArgument index,
198+
Tuple key,
199+
int offset,
200+
int limit,
201+
int iterator) {
202+
return exec(
203+
Code.SELECT,
204+
ofResolved(Key.SPACE), space,
205+
ofResolved(Key.INDEX), index,
206+
ofResolved(Key.KEY), ofResolved(key),
207+
ofResolved(Key.ITERATOR), ofResolved(iterator),
208+
ofResolved(Key.LIMIT), ofResolved(limit),
209+
ofResolved(Key.OFFSET), ofResolved(offset)
210+
);
211+
}
212+
62213
}

Diff for: src/main/java/org/tarantool/TarantoolBase.java

+1-11
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import java.util.List;
1010
import java.util.concurrent.atomic.AtomicLong;
1111

12-
public abstract class TarantoolBase<Result> extends AbstractTarantoolOps<Integer, List<?>, Object, Result> {
12+
public abstract class TarantoolBase<Result> extends AbstractTarantoolOps<List<?>, Object, Result> {
1313
protected String serverVersion;
1414
protected MsgPackLite msgPackLite = MsgPackLite.INSTANCE;
1515
protected AtomicLong syncId = new AtomicLong();
@@ -42,16 +42,6 @@ protected void closeChannel(SocketChannel channel) {
4242
}
4343
}
4444

45-
protected void validateArgs(Object[] args) {
46-
if (args != null) {
47-
for (int i = 0; i < args.length; i += 2) {
48-
if (args[i + 1] == null) {
49-
throw new NullPointerException(((Key) args[i]).name() + " should not be null");
50-
}
51-
}
52-
}
53-
}
54-
5545
public void setInitialRequestSize(int initialRequestSize) {
5646
this.initialRequestSize = initialRequestSize;
5747
}

Diff for: src/main/java/org/tarantool/TarantoolClient.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
import java.util.concurrent.TimeUnit;
88

99
public interface TarantoolClient {
10-
TarantoolClientOps<Integer, List<?>, Object, List<?>> syncOps();
10+
TarantoolClientOps<List<?>, Object, List<?>> syncOps();
1111

12-
TarantoolClientOps<Integer, List<?>, Object, Future<List<?>>> asyncOps();
12+
TarantoolClientOps<List<?>, Object, Future<List<?>>> asyncOps();
1313

14-
TarantoolClientOps<Integer, List<?>, Object, CompletionStage<List<?>>> composableAsyncOps();
14+
TarantoolClientOps<List<?>, Object, CompletionStage<List<?>>> composableAsyncOps();
1515

16-
TarantoolClientOps<Integer, List<?>, Object, Long> fireAndForgetOps();
16+
TarantoolClientOps<List<?>, Object, Long> fireAndForgetOps();
1717

1818
TarantoolSQLOps<Object, Long, List<Map<String, Object>>> sqlSyncOps();
1919

0 commit comments

Comments
 (0)